The International Simutrans Forum

Simutrans Extended => Simutrans-Extended bug reports => Simutrans-Extended development => Simutrans-Extended closed bug reports => Topic started by: jamespetts on January 30, 2022, 11:47:33 AM

Title: Crash on loading Bridgewater-Brunel save
Post by: jamespetts on January 30, 2022, 11:47:33 AM
The Bridgewater-Brunel server is down this morning because of a new crash on loading the saved game. The saved game is here (http://bridgewater-brunel.me.uk/saves/bb-crash-30-jan-2022.sve).

Testing with an older build, I confirm that this loads without crashing or other apparent error. Therefore, this would appear to be an issue introduced with yesterday's modifications.

The crash is in loading the first halt - it is an index out of bounds in the waiting time, trying to read back 9 values when there are in fact only 5 classes. This suggests that the error has actually occurred in the previous part of the loading, the lines, by them either loading too many or too few data, meaning that the file stream is in the wrong position by the time that it comes to reading the halts. Alternatively, the problem might have occurred earlier in the halt loading process.

I have not made any changes myself to this part of the code - I wonder whether the issue might have been caused by Ranran's changes to records for amounts of things transported or being processed at halts?
Title: Re: Crash on loading Bridgewater-Brunel save
Post by: Ranran on January 30, 2022, 12:41:15 PM
Sorry about that. I think an error in the revision number caused it.  :-[
Please check the pull request #484.
Title: Re: Crash on loading Bridgewater-Brunel save
Post by: jamespetts on January 30, 2022, 12:45:56 PM
Excellent, confirmed fixed.