The International Simutrans Forum

Development => Patches & Projects => Incorporated Patches and Solved Bug Reports => Topic started by: ansgar on May 05, 2011, 10:32:25 PM

Title: another buffer overflow in gui/depot_frame.cc
Post by: ansgar on May 05, 2011, 10:32:25 PM
Hi,

after I applied the patch for the buffer overflow in [1], I found another one due to txt_convoi_value also being to small.  This caused another crash when building with hardening flags and choosing Russian.

Please consider applying the attached patch.

Regards,
Ansgar

[1] http://forum.simutrans.com/index.php?topic=7231.0
Title: Re: another buffer overflow in gui/depot_frame.cc
Post by: prissi on May 06, 2011, 12:20:48 PM
Increase, but imho this should be changed to money2string and buffer to avoid furhter bufffer overflows ...