Recent Posts

1

Social & Contests / Re: Simutrans Steam Screenshot Contest #2

« Last post by Yona-TYT on Today at 06:23:53 AM »

I am having trouble exercising my right to vote.

2

Simutrans-Extended major projects / Re: New system for elevated ways (inc. half height and uneven terrain)

« Last post by PJMack on Today at 03:40:42 AM »

I have attached some screenshots of the graphics that are working on my machine.  I do not know why it is doing that on your machine, but I suspect for some reason there is an issue with loading (or generating) the pakset as the automated build tool has redundant checks in it (the build restrictions are taken into account for route finding and checked again during building).  Makeobj passed with Valgrind.  I put the Valgrind errors for simutrans-extend below (while building a steel pier), which contains no errors relevant to the pier system.  At this point, I am not sure quite what to do.  Has anyone else tested this?

Code: [Select]

==258325== Memcheck, a memory error detector
==258325== Copyright (C) 2002-2017, and GNU GPL'd, by Julian Seward et al.
==258325== Using Valgrind-3.15.0 and LibVEX; rerun with -h for copyright info
==258325== Command: ./simutrans/simutrans-extended
==258325==
Parsed simuconf.tab for directory layout; multiuser = 1
Pak found: pak128.Britain-Ex/
==258325== Conditional jump or move depends on uninitialised value(s)
==258325==    at 0x53D4565: pa_shm_cleanup (in /usr/lib/x86_64-linux-gnu/pulseaudio/libpulsecommon-13.99.so)
==258325==    by 0x53D47A1: pa_shm_create_rw (in /usr/lib/x86_64-linux-gnu/pulseaudio/libpulsecommon-13.99.so)
==258325==    by 0x53C44B6: pa_mempool_new (in /usr/lib/x86_64-linux-gnu/pulseaudio/libpulsecommon-13.99.so)
==258325==    by 0x51539B1: pa_context_new_with_proplist (in /usr/lib/x86_64-linux-gnu/libpulse.so.0.21.2)
==258325==    by 0x4C72D5E: ??? (in /usr/lib/x86_64-linux-gnu/libSDL2-2.0.so.0.10.0)
==258325==    by 0x4C7365A: ??? (in /usr/lib/x86_64-linux-gnu/libSDL2-2.0.so.0.10.0)
==258325==    by 0x4BC5D9B: ??? (in /usr/lib/x86_64-linux-gnu/libSDL2-2.0.so.0.10.0)
==258325==    by 0x4BC1906: ??? (in /usr/lib/x86_64-linux-gnu/libSDL2-2.0.so.0.10.0)
==258325==    by 0x2BBF97: UnknownInlinedFun (sdl2_sound.cc:119)
==258325==    by 0x2BBF97: UnknownInlinedFun (sdl2_sound.cc:110)
==258325==    by 0x2BBF97: UnknownInlinedFun (simmain.cc:1173)
==258325==    by 0x2BBF97: sysmain(int, char**) (simsys.cc:1097)
==258325==    by 0x489F0B2: (below main) (libc-start.c:308)
==258325==
==258325== Conditional jump or move depends on uninitialised value(s)
==258325==    at 0x367FF1: fabrik_t::calc_operation_rate(signed char) const [clone .part.0] (simfab.cc:4118)
==258325==    by 0x377836: UnknownInlinedFun (simfab.cc:4106)
==258325==    by 0x377836: fabrik_t::rdwr(loadsave_t*) (simfab.cc:1726)
==258325==    by 0x2C9B47: UnknownInlinedFun (simfab.cc:835)
==258325==    by 0x2C9B47: karte_t::load(loadsave_t*) (simworld.cc:9727)
==258325==    by 0x2CF045: karte_t::load(char const*) (simworld.cc:9135)
==258325==    by 0x2B932D: UnknownInlinedFun (simmain.cc:1493)
==258325==    by 0x2B932D: sysmain(int, char**) (simsys.cc:1097)
==258325==    by 0x489F0B2: (below main) (libc-start.c:308)
==258325==
==258325== Conditional jump or move depends on uninitialised value(s)
==258325==    at 0x367FF9: fabrik_t::calc_operation_rate(signed char) const [clone .part.0] (simfab.cc:4127)
==258325==    by 0x377836: UnknownInlinedFun (simfab.cc:4106)
==258325==    by 0x377836: fabrik_t::rdwr(loadsave_t*) (simfab.cc:1726)
==258325==    by 0x2C9B47: UnknownInlinedFun (simfab.cc:835)
==258325==    by 0x2C9B47: karte_t::load(loadsave_t*) (simworld.cc:9727)
==258325==    by 0x2CF045: karte_t::load(char const*) (simworld.cc:9135)
==258325==    by 0x2B932D: UnknownInlinedFun (simmain.cc:1493)
==258325==    by 0x2B932D: sysmain(int, char**) (simsys.cc:1097)
==258325==    by 0x489F0B2: (below main) (libc-start.c:308)
==258325==
==258325== Conditional jump or move depends on uninitialised value(s)
==258325==    at 0x352E7D: simline_t::recalc_status() (simline.cc:744)
==258325==    by 0x35545C: simline_t::create_schedule() (simline.cc:181)
==258325==    by 0x355C3A: UnknownInlinedFun (simline.cc:96)
==258325==    by 0x355C3A: simlinemgmt_t::rdwr(loadsave_t*, player_t*) (simlinemgmt.cc:133)
==258325==    by 0x41D77E: player_t::rdwr(loadsave_t*) (simplay.cc:916)
==258325==    by 0x2CAEBC: karte_t::load(loadsave_t*) (simworld.cc:9809)
==258325==    by 0x2CF045: karte_t::load(char const*) (simworld.cc:9135)
==258325==    by 0x2B932D: UnknownInlinedFun (simmain.cc:1493)
==258325==    by 0x2B932D: sysmain(int, char**) (simsys.cc:1097)
==258325==    by 0x489F0B2: (below main) (libc-start.c:308)
==258325==
==258325== Conditional jump or move depends on uninitialised value(s)
==258325==    at 0x352EDD: simline_t::recalc_status() (simline.cc:756)
==258325==    by 0x35545C: simline_t::create_schedule() (simline.cc:181)
==258325==    by 0x355C3A: UnknownInlinedFun (simline.cc:96)
==258325==    by 0x355C3A: simlinemgmt_t::rdwr(loadsave_t*, player_t*) (simlinemgmt.cc:133)
==258325==    by 0x41D77E: player_t::rdwr(loadsave_t*) (simplay.cc:916)
==258325==    by 0x2CAEBC: karte_t::load(loadsave_t*) (simworld.cc:9809)
==258325==    by 0x2CF045: karte_t::load(char const*) (simworld.cc:9135)
==258325==    by 0x2B932D: UnknownInlinedFun (simmain.cc:1493)
==258325==    by 0x2B932D: sysmain(int, char**) (simsys.cc:1097)
==258325==    by 0x489F0B2: (below main) (libc-start.c:308)
==258325==
==258325== Conditional jump or move depends on uninitialised value(s)
==258325==    at 0x352EF9: simline_t::recalc_status() (simline.cc:762)
==258325==    by 0x35545C: simline_t::create_schedule() (simline.cc:181)
==258325==    by 0x355C3A: UnknownInlinedFun (simline.cc:96)
==258325==    by 0x355C3A: simlinemgmt_t::rdwr(loadsave_t*, player_t*) (simlinemgmt.cc:133)
==258325==    by 0x41D77E: player_t::rdwr(loadsave_t*) (simplay.cc:916)
==258325==    by 0x2CAEBC: karte_t::load(loadsave_t*) (simworld.cc:9809)
==258325==    by 0x2CF045: karte_t::load(char const*) (simworld.cc:9135)
==258325==    by 0x2B932D: UnknownInlinedFun (simmain.cc:1493)
==258325==    by 0x2B932D: sysmain(int, char**) (simsys.cc:1097)
==258325==    by 0x489F0B2: (below main) (libc-start.c:308)
==258325==
==258325== Conditional jump or move depends on uninitialised value(s)
==258325==    at 0x352FDE: simline_t::recalc_status() (simline.cc:769)
==258325==    by 0x35545C: simline_t::create_schedule() (simline.cc:181)
==258325==    by 0x355C3A: UnknownInlinedFun (simline.cc:96)
==258325==    by 0x355C3A: simlinemgmt_t::rdwr(loadsave_t*, player_t*) (simlinemgmt.cc:133)
==258325==    by 0x41D77E: player_t::rdwr(loadsave_t*) (simplay.cc:916)
==258325==    by 0x2CAEBC: karte_t::load(loadsave_t*) (simworld.cc:9809)
==258325==    by 0x2CF045: karte_t::load(char const*) (simworld.cc:9135)
==258325==    by 0x2B932D: UnknownInlinedFun (simmain.cc:1493)
==258325==    by 0x2B932D: sysmain(int, char**) (simsys.cc:1097)
==258325==    by 0x489F0B2: (below main) (libc-start.c:308)
==258325==
==258325== Thread 39:
==258325== Conditional jump or move depends on uninitialised value(s)
==258325==    at 0x59CCB1: wayobj_t::get_image() const (wayobj.h:59)
==258325==    by 0x5A8039: obj_t::display(int, int, signed char) const (simobj.cc:210)
==258325==    by 0x600F2C: UnknownInlinedFun (objlist.cc:1128)
==258325==    by 0x600F2C: UnknownInlinedFun (objlist.cc:1144)
==258325==    by 0x600F2C: grund_t::display_obj_bg(short, short, bool, bool, bool, signed char) const (grund.cc:1763)
==258325==    by 0x60515E: grund_t::display_obj_all(short, short, short, bool, signed char) const (grund.cc:1674)
==258325==    by 0x335C6C: planquadrat_t::display_obj(short, short, short, bool, signed char, signed char, signed char) const (simplan.cc:547)
==258325==    by 0x20087D: main_view_t::display_region(koord, koord, short, short, bool, bool, signed char) [clone .constprop.0] (simview.cc:576)
==258325==    by 0x58D4B6: display_region_thread(void*) (simview.cc:77)
==258325==    by 0x4B1C608: start_thread (pthread_create.c:477)
==258325==    by 0x499A292: clone (clone.S:95)
==258325==
==258325== Conditional jump or move depends on uninitialised value(s)
==258325==    at 0x59CCB1: wayobj_t::get_image() const (wayobj.h:59)
==258325==    by 0x5A8039: obj_t::display(int, int, signed char) const (simobj.cc:210)
==258325==    by 0x600F2C: UnknownInlinedFun (objlist.cc:1128)
==258325==    by 0x600F2C: UnknownInlinedFun (objlist.cc:1144)
==258325==    by 0x600F2C: grund_t::display_obj_bg(short, short, bool, bool, bool, signed char) const (grund.cc:1763)
==258325==    by 0x604721: grund_t::display_obj_all(short, short, short, bool, signed char) const (grund.cc:1633)
==258325==    by 0x335C6C: planquadrat_t::display_obj(short, short, short, bool, signed char, signed char, signed char) const (simplan.cc:547)
==258325==    by 0x20087D: main_view_t::display_region(koord, koord, short, short, bool, bool, signed char) [clone .constprop.0] (simview.cc:576)
==258325==    by 0x58D4B6: display_region_thread(void*) (simview.cc:77)
==258325==    by 0x4B1C608: start_thread (pthread_create.c:477)
==258325==    by 0x499A292: clone (clone.S:95)
==258325==
==258325== Conditional jump or move depends on uninitialised value(s)
==258325==    at 0x59CCB1: wayobj_t::get_image() const (wayobj.h:59)
==258325==    by 0x5A8039: obj_t::display(int, int, signed char) const (simobj.cc:210)
==258325==    by 0x600F2C: UnknownInlinedFun (objlist.cc:1128)
==258325==    by 0x600F2C: UnknownInlinedFun (objlist.cc:1144)
==258325==    by 0x600F2C: grund_t::display_obj_bg(short, short, bool, bool, bool, signed char) const (grund.cc:1763)
==258325==    by 0x60507E: grund_t::display_obj_all(short, short, short, bool, signed char) const (grund.cc:1682)
==258325==    by 0x335C6C: planquadrat_t::display_obj(short, short, short, bool, signed char, signed char, signed char) const (simplan.cc:547)
==258325==    by 0x20087D: main_view_t::display_region(koord, koord, short, short, bool, bool, signed char) [clone .constprop.0] (simview.cc:576)
==258325==    by 0x58D4B6: display_region_thread(void*) (simview.cc:77)
==258325==    by 0x4B1C608: start_thread (pthread_create.c:477)
==258325==    by 0x499A292: clone (clone.S:95)
==258325==
==258325== Conditional jump or move depends on uninitialised value(s)
==258325==    at 0x59CAD1: wayobj_t::get_front_image() const (wayobj.h:69)
==258325==    by 0x5A7E3E: obj_t::display_after(int, int, signed char) const (simobj.cc:285)
==258325==    by 0x600A2C: UnknownInlinedFun (objlist.cc:1105)
==258325==    by 0x600A2C: UnknownInlinedFun (objlist.cc:1073)
==258325==    by 0x600A2C: grund_t::display_obj_fg(short, short, bool, unsigned char, signed char) const (grund.cc:1789)
==258325==    by 0x604D8A: grund_t::display_obj_all(short, short, short, bool, signed char) const (grund.cc:1731)
==258325==    by 0x335C6C: planquadrat_t::display_obj(short, short, short, bool, signed char, signed char, signed char) const (simplan.cc:547)
==258325==    by 0x20087D: main_view_t::display_region(koord, koord, short, short, bool, bool, signed char) [clone .constprop.0] (simview.cc:576)
==258325==    by 0x58D4B6: display_region_thread(void*) (simview.cc:77)
==258325==    by 0x4B1C608: start_thread (pthread_create.c:477)
==258325==    by 0x499A292: clone (clone.S:95)
==258325==
==258325== Thread 1:
==258325== Conditional jump or move depends on uninitialised value(s)
==258325==    at 0x2957A5: road_vehicle_t::enter_tile(grund_t*) (road_vehicle.cc:1105)
==258325==    by 0x28B039: vehicle_t::hop(grund_t*) (vehicle.cc:1685)
==258325==    by 0x293D4A: road_vehicle_t::hop(grund_t*) (road_vehicle.cc:1141)
==258325==    by 0x28F03D: vehicle_base_t::do_drive(unsigned int) (vehicle.cc:332)
==258325==    by 0x28F20C: road_vehicle_t::do_drive(unsigned int) (road_vehicle.cc:1042)
==258325==    by 0x39E109: UnknownInlinedFun (simconvoi.cc:1333)
==258325==    by 0x39E109: convoi_t::sync_step(unsigned int) (simconvoi.cc:1226)
==258325==    by 0x2DBE3D: karte_t::sync_list_t::sync_step(unsigned int) (simworld.cc:4864)
==258325==    by 0x2DBFC8: karte_t::sync_step(unsigned int, bool, bool) (simworld.cc:4937)
==258325==    by 0x201F38: UnknownInlinedFun (simintr.cc:111)
==258325==    by 0x201F38: interrupt_check(char const*) [clone .constprop.0] (simintr.cc:91)
==258325==    by 0x2D7DFC: karte_t::step() (simworld.cc:5699)
==258325==    by 0x345745: UnknownInlinedFun (simmain.cc:268)
==258325==    by 0x345745: modal_dialogue(gui_frame_t*, long, karte_t*, bool (*)()) (simmain.cc:200)
==258325==    by 0x2BAB31: UnknownInlinedFun (simmain.cc:1617)
==258325==    by 0x2BAB31: sysmain(int, char**) (simsys.cc:1097)
==258325==
==258325== Conditional jump or move depends on uninitialised value(s)
==258325==    at 0x2957A5: road_vehicle_t::enter_tile(grund_t*) (road_vehicle.cc:1105)
==258325==    by 0x39EE53: convoi_t::move_to(unsigned short) (simconvoi.cc:478)
==258325==    by 0x399BCA: UnknownInlinedFun (simconvoi.cc:3486)
==258325==    by 0x399BCA: convoi_t::step() (simconvoi.cc:2224)
==258325==    by 0x2D7F6D: karte_t::step() (simworld.cc:5807)
==258325==    by 0x2C474D: karte_t::interactive(unsigned int) (simworld.cc:11425)
==258325==    by 0x2BA9FE: UnknownInlinedFun (simmain.cc:1644)
==258325==    by 0x2BA9FE: sysmain(int, char**) (simsys.cc:1097)
==258325==    by 0x489F0B2: (below main) (libc-start.c:308)


3

Bug Reports / Re: any corner generate ground in the sea.[r10359]

« Last post by myagami on Today at 02:56:27 AM »

Beach generation was broken. Fixed in r10363

This uncovered another problem: Since beach generation is from left top to right bottom, beach would grow to the bottom right, or one get very few beaches (like right now).

Thanks,I tried check fix in r10367.

4

Simutrans-Extended development / Re: Server compilation issues after merging nightly pull requests

« Last post by Sirius on Today at 01:41:06 AM »

Sirius - can I check whether the Windows 64-bit nightly builds are working fully on Github now? Has anyone tested their performance against the builds from the server?

Win 64 bit minGW build are working quite well for a long time. Only MSVC SDL2 builds were broken.
Good news: Both are working now.

About the performance, I didn't benchmark these but the github build is using just the same compile options as any other Release CMake build in default setup.
If you are using any specific optimisations on BB, you might share these so they can find their way into the nightlies on github.

Edit: as for now, the full package doesn't seem to be working. Should now be fixed now. I'll se the results tomorrow (nightly should run in roughly 1 hour automatically)

5

Simutrans-Extended major projects / Re: New system for elevated ways (inc. half height and uneven terrain)

« Last post by jamespetts on Today at 12:21:14 AM »

Thanks to Roboron's assistance, I have managed to get this compiling again in Visual Studio, as well as fixing the problem with the master branch on the server, so we can return to focussing on the elevated way support system itself.

I can confirm that deleting a new elevated way support with parapets now automatically deletes both parapet and deck as intended - this is helpful. I have now merged in PJMack's latest pakset build.

However, we still get this odd form of support when building the structures:



and the steel (iron?) type still refuses to build at all, claiming that it cannot find a valid route. I am not sure why this is. This appears to be a special type of support that allows ways to run underneath the structure - is this correct? Do we have any historical examples of this in a brick arch structure? The height above the road below appears very low - I assume that vehicles marked "is_tall" would not be able to pass underneath?

I can confirm that the parapets are now no longer present on depots and stations, although this leaves 'bus stops on top of these elevated ways looking very odd:



I am not sure what is best to do about this, but it merits further consideration in any event.

Thank you again for all your work on this.

6

Bug Reports / Re: r9274 Win10 Pak128 - Train line not "connecting" passenger destinations

« Last post by kzwix on Yesterday at 11:29:41 PM »

I *did* post the savegame (just click the link).
As stated, it couldn't be included in the message itself (It rejected my message because the file was too big, losing all the text in the process - so, I used Simutrans File Sharing instead the second time)

7

Bug Reports / Re: r9274 Win10 Pak128 - Train line not "connecting" passenger destinations

« Last post by Yona-TYT on Yesterday at 11:11:56 PM »

Maybe posting the savegame can help.

8

Bug Reports / r9274 Win10 Pak128 - Train line not "connecting" passenger destinations

« Last post by kzwix on Yesterday at 10:35:55 PM »

Hello,
I had a nice passenger network, with lots of buses, tramways in the largest cities, buses connecting cities... it worked quite well.
Then, I wanted to replace a high-traffic connection with a fast train. So, I set a fast train line, connected with existing stations in the cities lines (same as a tramway or bus stop), and put a passenger train there.

However, most of the traffic was still going through the inter-cities bus line, instead of going through my brand new shiny (and expensive) express train. So, I deleted the bus line between Lancaster and Cambridge
(save here: https://simutrans-germany.com/files/upload/K4_Pak128_(bug).sve - was to heavy to upload in the post), and expected the traffic to shift through the train line.

Well, it disappeared instead, as if the two "parts" of the transport network were no longer connected. I think it's a bug, as I clearly recall having been able to do that in the past.
If you need an earlier savegame (when I still had a bus line, and possibly no train line there), please ask, I'll be happy to provide it.

9

Considered Patches / Re: Add theme parameters to make dark themes look better

« Last post by Ranran on Yesterday at 09:52:05 PM »

In the convoi info line of combobox these are SYSCOL_TEXT. (gui_color_text)

The entry to edit are SYSCOL_EDIT_TEXT or ..._DISABLED (gui_color_edit_text or ..._disabled)

So they should be different

Thanks for the information. It worked. I overlooked this setting because I have not seen such a combo box before.
That is, as reported above, the depot dialog combo box may be disabled, but it does not change its appearance to look like it is disabled.
e.g. a depot dialog that cannot be manipulated by another player. This is also the case with extended.

The color to be masked is fixed at black.

This case do not exist in extended, but I think SYSCOL_TEXT should be used instead of COL_BLACK.
Because SYSCOL_TEXT should always use a color with a certain visibility against the GUI background. So it will be suitable for any theme.

10

Incorporated patches/merged pull requests / Re: Add km to the values on the distance chart

« Last post by jamespetts on Yesterday at 09:46:19 PM »

Excellent - thank you: now incorporated.