Recent posts

#81

Incorporated Patches and Solved Bug Reports / Re: [r10754+] SDL_QUIT is igno...

Last post by prissi - April 02, 2024, 01:16:30 PM

r11106 fixes this, thnak you.

#82

Incorporated Patches and Solved Bug Reports / Re: UI afterimage on the outsi...

Last post by prissi - April 02, 2024, 12:50:18 PM

Good catch, must be there for ages. Also it does not happen with all paksets, only if they do not use the outside graphic for the outside ...

r11106 fixes this.

#83

Incorporated Patches and Solved Bug Reports / UI afterimage on the outside

Last post by Ranran(retired) - April 02, 2024, 10:43:23 AM

When the dialog is minimized, the part that was outside will remain as an afterimage.
I think we should dirty the area where the dialog was when the minimize is performed.

#84

Incorporated Patches and Solved Bug Reports / Re: "Play Tutorial" button

Last post by Ranran(retired) - April 02, 2024, 10:19:44 AM

https://github.com/aburch/simutrans/blob/c45b4d40fc9e4ce43d5e0ea3acad400eadf67ef6/src/simutrans/gui/banner.h#L32
I believe "button_t credits" defined here is not used.

#85

Patches & Projects / Re: r11101 expanded numberinpu...

Last post by prissi - April 02, 2024, 08:41:09 AM

I think this is the way ceeac wants to go and as long term goal this is certainly the best way. Alternatively, one could give the numberinput a default minimum width of 4 digits, and then they would align nicer, at least the smaller numbers.

r11105 enforces five digits minimum width. Maybe this should be a themeable parameter?

#86

Patches & Projects / Re: r11101 expanded numberinpu...

Last post by Ranran(retired) - April 01, 2024, 10:48:16 PM

I think that by properly combining table and gui_fill_t, you can maintain alignment while preventing the width from becoming too wide.
The red frame is a table with two horizontal rows.
Then put gui_fill_t in the blue frame.

#87

Patches & Projects / Re: r11101 expanded numberinpu...

Last post by isidoro - March 31, 2024, 11:34:16 PM

In my opinion, aligned input fields look much nicer than irregular ones.

#88

Simutrans Help Center / Re: Passengers don't enter tra...

Last post by Antonin - March 31, 2024, 07:19:25 PM

Hmmm. After making the change suggested above, I still have the same issue. People want to travel between the 2 cities, but only one passenger will ride my shiny new passenger train. Oh well. I think I will start a new map.

#89

Incorporated Patches and Solved Bug Reports / [r10754+] SDL_QUIT is ignored ...

Last post by ceeac - March 31, 2024, 06:20:11 PM

Since r10754, closing the main window using the x button does not work most of the time while the banner window is open. Seems to work after multiple repeated attempts (usually 5+, this is variable). Control-C in the terminal to exit the program does not work most of the time either. The program receives an SDL_QUIT message from SDL, but the corresponding sys_event seems to be ignored.

#90

Patches & Projects / Re: r11101 expanded numberinpu...

Last post by ceeac - March 31, 2024, 06:00:11 PM

IMO the stretchable numberinputs look much nicer, this is the primary reason why I changed it. Also, other components like comboboxes or textinputs are stretchable too, so it is more consistent if numberinputs are stetchable, too.

For that, one would need to add a third row of dummy objects ... can be done, but would need to be done for each of the affected dialogues. (Also the display settings i.e for traffic or map are now very wide.)

It would indeed be a larger change to check and change all the dialogues containing numberinputs. I think it would be best to revert the change right now (since reverting to the previous behaviour does not break anything), and then redo the change properly after the release since I want to focus on GUI improvements after the release anyway.