Using the water way removal tool crashes the game

[Spenk009]

Using the water way remover (x) crashes the game when clicking on any river or canal tile. Tested in nightly/self compiled newest version.

[Matthew]

I also get this.

[jamespetts]

Thank you both for your reports. I believe that I have now fixed this on the private-car-routing-memory-saving branch. I should be grateful if you could re-test with that branch, which I am hoping to integrate soon once it has been tested, to see whether this has been fixed. Thank you.

[Matthew]

I can now destroy canals and canalized rivers using the water-way-remover tool with commit #d33d9dd, so thank you for making progress with this bug.

I cannot destroy streams (natural, non-navigable waterways) using the tool. Mostly I get an error message saying "Ways not connected". But one time I got a crash with this GDB backtrace:

Maybe we are not supposed to be able to use this tool with streams, but I thought that we could in the past.

EDIT: The crash was with an earlier commit, apologies.

[jamespetts]

This would be caused by the fact that the way removal tool uses a special sort of vehicle to iterate along the way tiles (a design from Standard): because streams are unnavigable, the special vehicle cannot find a route along them.

[Spenk009]

Thank you very much, confirmed as fixed.

[jamespetts]

Splendid,m thank you for confirming.