The International Simutrans Forum

 

Author Topic: BAE_146_100 (Dan Air)  (Read 1759 times)

0 Members and 1 Guest are viewing this topic.

Offline Milko

  • Devotee
  • *
  • Posts: 829
BAE_146_100 (Dan Air)
« on: June 11, 2012, 08:44:18 PM »
Hello James

In github there are two ".dat" files: BAE_146_100.dat and BAE_146_100_danairlondon.dat

The contents of two files is almost the same, I do not know which is correct. BAE_146_100_danairlondon.dat has "weight = 29.5", which must be corrected to "weight = 29"

Giuseppe

Offline jamespetts gb

  • Simutrans-Extended project coordinator
  • Moderator
  • *
  • Posts: 18721
  • Cake baker
    • Bridgewater-Brunel
  • Languages: EN
Re: BAE_146_100 (Dan Air)
« Reply #1 on: June 11, 2012, 10:01:50 PM »
Thank you for spotting this! .dat files cannot accept decimals (or negative numbers), so the one without the decimal must be the correct one. I shall fix it now.

Offline Milko

  • Devotee
  • *
  • Posts: 829
Re: BAE_146_100 (Dan Air)
« Reply #2 on: June 12, 2012, 07:27:01 AM »
Hello James

Also BAE_146_300_JerseyEuropean.dat has the problem. weight=30,8 be corrected in weight=31

About the name of the file BAE_146_100.dat, perhaps, to maintain uniformity in names, is not it better to rename the file BAE_146_100_danairlondon.dat?

Giuseppe

Offline jamespetts gb

  • Simutrans-Extended project coordinator
  • Moderator
  • *
  • Posts: 18721
  • Cake baker
    • Bridgewater-Brunel
  • Languages: EN
Re: BAE_146_100 (Dan Air)
« Reply #3 on: June 12, 2012, 09:04:01 AM »
Ahh, thank you for spotting that. If I were inclined to change the names, I'd be more inclined to remove rather than add reference to liveries, as it would be good one day to have multiple livery variants of aircraft.

Offline Milko

  • Devotee
  • *
  • Posts: 829
Re: BAE_146_100 (Dan Air)
« Reply #4 on: June 18, 2012, 09:36:33 AM »
Hello James

Also BAE_146_300_JerseyEuropean.dat has the problem. weight=30,8 be corrected in weight=31

30.8 -> 31 (not 30 ...)  :)

Reminder: name of BAE_146_100.dat.

Giuseppe