The International Simutrans Forum

 

Author Topic: 112.0 - filters on vehicle list non-functional  (Read 1937 times)

0 Members and 1 Guest are viewing this topic.

Offline Fraoch

  • *
  • Posts: 81
  • Languages: EN, FR
112.0 - filters on vehicle list non-functional
« on: November 06, 2012, 08:49:59 PM »
Simutrans 112.0 r6000 with pakset pak128 2.1.0 on Ubuntu Linux 12.10 64-bit.  I'd use a nightly but I don't have the skills to compile it.

Changing anything in the settings box in the filter settings window seems to have no effect.  It's forgotten when the screen is closed and the vehicle list never changes.  The Enable/Disable button seems to have no effect either.

This worked fine in previous versions and I'm using the window the same way.
« Last Edit: November 06, 2012, 08:58:58 PM by Fraoch »

Offline Zeno

  • ENASSA Designer
  • Devotees (Inactive)
  • *
  • Posts: 1997
    • Zeno's Simutrans Creations
  • Languages: ES, EN, CAT
Re: 112.0 - filters on vehicle list non-functional
« Reply #1 on: November 06, 2012, 09:48:16 PM »
I've just tested that too and it seems that everything works until you press the "Enable" button. Then everything seems to get messed up and looks like nothing works there...

Offline prissi

  • Developer
  • Administrator
  • *
  • Posts: 10636
  • Languages: De,EN,JP
Re: 112.0 - filters on vehicle list non-functional
« Reply #2 on: November 06, 2012, 09:51:58 PM »
Even switching the filter off does not work any more ...

Online Dwachs

  • DevTeam, Coder/patcher
  • Administrator
  • *
  • Posts: 4869
  • Languages: EN, DE, AT
Re: 112.0 - filters on vehicle list non-functional
« Reply #3 on: November 18, 2012, 11:35:50 AM »
should be fixed with r6064. Please test again.

Offline prissi

  • Developer
  • Administrator
  • *
  • Posts: 10636
  • Languages: De,EN,JP
Re: 112.0 - filters on vehicle list non-functional
« Reply #4 on: November 18, 2012, 04:18:02 PM »
Was already fixed before in r6033.

Why do you switch the filter off during reopening? That way after joining the filters are always off.

Online Dwachs

  • DevTeam, Coder/patcher
  • Administrator
  • *
  • Posts: 4869
  • Languages: EN, DE, AT
Re: 112.0 - filters on vehicle list non-functional
« Reply #5 on: November 18, 2012, 07:10:36 PM »
Could be changed to a static variable. No problem. But then the filter state should also be preserved, which is not the case atm.

The problem with not initializing was that then the boolean variable had strange values, ie something like 241 (not 0 or 1). Then pressing the toggle-filter button had no effect.

Offline prissi

  • Developer
  • Administrator
  • *
  • Posts: 10636
  • Languages: De,EN,JP
Re: 112.0 - filters on vehicle list non-functional
« Reply #6 on: November 18, 2012, 07:45:11 PM »
Ahh, I see. Indeed, my fault. Since the other setting are preserved (they are static), maybe this should be made static too?