The International Simutrans Forum

 

Author Topic: Release candidate (minimap)  (Read 1118 times)

0 Members and 1 Guest are viewing this topic.

Offline Carl

  • Devotee
  • *
  • Posts: 1602
    • Website
  • Languages: EN
Release candidate (minimap)
« on: December 03, 2012, 11:59:05 AM »
Just running this on a large existing save and so far most things seem smooth. No obvious gamebreaking bugs, and performance is more or less the same as on 10.15.

Only two things to note so far, both related to the minimap. First, it appears that the minimap cannot be zoomed in any further than 1:1 (previously one could go to 1:3, though there was a crash on going to 1:4). Is this working as intended? Second, it appears that the "pass dest." button doesn't have any effect on the minimap. Is this working?

I should stress that so far I've only been running an existing map on fast forward -- there may well be bugs arising from other activities!

Offline jamespetts gb

  • Simutrans-Extended project coordinator
  • Moderator
  • *
  • Posts: 18745
  • Cake baker
    • Bridgewater-Brunel
  • Languages: EN
Re: Release candidate (minimap)
« Reply #1 on: December 03, 2012, 12:45:06 PM »
The issue with the passenger destinations feature is known - it's not that it has no effect, but rather that the representations consist of a joined pair of long lines rather than solid boxes, making them difficult to spot and imprecise to locate.

I can't reproduce the zooming issue on the minimap - I can go in to 1:16 on demo.sve or 1:7 on the Bridgewater-Brunel server game (previously, I could only go into 1:4 - I cannot reproduce the crash that you describe in 10.15 on going to 1:4). What system, etc. are you using...?

Offline Carl

  • Devotee
  • *
  • Posts: 1602
    • Website
  • Languages: EN
Re: Release candidate (minimap)
« Reply #2 on: December 03, 2012, 12:50:12 PM »
Interesting. On my Balkans map I can zoom in to 1:6, but on the GB map (which I believe you have a version of from other bug tests) I can only zoom to 1:1. That is very strange. (I wonder why this varies between maps at all?)

As for the crash bug, that does indeed seem to have disappeared somewhere inbetween 10.12 and 10.15.

Offline Dwachs

  • DevTeam, Coder/patcher
  • Administrator
  • *
  • Posts: 4601
  • Languages: EN, DE, AT
Re: Release candidate (minimap)
« Reply #3 on: December 03, 2012, 03:02:44 PM »
Interesting. On my Balkans map I can zoom in to 1:6, but on the GB map (which I believe you have a version of from other bug tests) I can only zoom to 1:1. That is very strange. (I wonder why this varies between maps at all?)

As for the crash bug, that does indeed seem to have disappeared somewhere inbetween 10.12 and 10.15.
The crash bug was fixed in standard 6 months ago, maybe merged recently into experimental ?

The restriction to zoom-in level is due to some limitations in the implementation. (to prevent integer overflows)

Offline Bernd Gabriel

  • *
  • Posts: 230
  • Addicted to Simutrans: since 2003
    • Fast Function Factory
  • Languages: DE, EN, C++
Re: Release candidate (minimap)
« Reply #4 on: December 03, 2012, 07:44:12 PM »
The zoom factor is limited by

min( 32767 / (2*get_welt()->get_groesse_max()), 16)

Thus the maximum zoom of 16 is available for maps with less than 1024 pixel in either direction only.