News:

Simutrans Sites
Know our official sites. Find tools and resources for Simutrans.

compile errors 6161

Started by kierongreen, December 09, 2012, 10:59:02 PM

Previous topic - Next topic

0 Members and 1 Guest are viewing this topic.

kierongreen

network_cmd_ingame.cc version 6161 doesn't compile under mingw as chdir is not recognised. Including unistd.h fixes this issue but I don't know if that is the correct solution...

Works fine compiling under normal Linux.

makeobj.cc doesn't compile either as init_logging has the wrong number of parameters.

Dwachs

Parsley, sage, rosemary, and maggikraut.

TurfIt

Changed pos.z to get_pos().z to allow 6163 compile. Not sure if this was what was intended....

Ters

Maybe ding_t::get_pos() should return const koord3d & and not koord3d to avoid copying the return value, but the compiler has a good chance of figuring out that such copying can be skipped here itself.

Dwachs

Quote from: TurfIt on December 10, 2012, 11:09:15 PM
Changed pos.z to get_pos().z to allow 6163 compile. Not sure if this was what was intended....
Iirc, the value of pos is NOT yet initialized in rdwr, it is available upon call to laden_abschliessen ... This check should be moved to laden_abschliessen instead.
Parsley, sage, rosemary, and maggikraut.

prissi


TurfIt

simrand is not allowed in multithreaded laden_abschliessen...

prissi

#7
Ok, r6175 might be anyway desync often on load ...

EDIT: no code in laden_abschliessen anyway any more.