Crash when reloading with older Pak128

[whoami]

This savegame was saved with ST r6162 and Pak128-r1092 as available here (replacing the busses by the ones from Zeno, but that should not matter for this bug). When reloading the savegame with Pak128 V2.1.0, ST (tested: r6162 and also V112) exits with an access violation. The "-log 5 -debug" output does not show anything unusual, in fact, it shows very little information. (Addons should not be necessary at all. The current Pak128 state replaces a lot of V2.1.0 ways including bridges, so lots of warnings are expectable at downgrading.)

Note (or rather, second bug): there are two (very old) corrupted markers at (134,90,0) and (134,89,0) (which is also a station). Trying to delete the latter (press Backspace and return in the dialog) causes ST to exit as well, but differently from above. They probably originate from trying to attach a label to a tunnel waypoint (does not work) and/or elevating terrain after setting the marker and/or placing a station, whatever. I learnt to avoid this tile.

[Dwachs]

The crash on loading is fixed in r6184, there is the powerline tunnel objects missing. Removing the tunnel will crash the game again.

Maybe we should do a fatal error thing here?

Edit: broken label will be repaired with r6185

[prissi]

Yes, why not? Before we had more fatal errors on missing stuff. The other way would be a default tunnel (road or so) which you did. But I think fatal error is the best solution, telling which object is missing (as it can do on load time, since it got the string).

[Dwachs]

Seems not so easy: in tunnel_t::rdwr the waytype is not known (so we cannot try a default tunnel), in laden_abschliessen the missing tunnel's name is not available, the fatal error message will be not helpful.

[prissi]

Thus only missing tunnel for waytype xyz then or just "No waytype at all for xxx". The waytpye string could be recreate from the besch_writer list.

[whoami]

Removing the tunnel will crash the game again.

True. The funny thing is: in the downgraded savegame, the overground images for the power lines appear. Is this from a preliminary implementation of underground power lines? If yes, why doesn't it work?

broken label will be repaired with r6185

Thank you, this works for the crashy label. The strange one next to it it still there, but causes no problems.

[Dwachs]

True. The funny thing is: in the downgraded savegame, the overground images for the power lines appear. Is this from a preliminary implementation of underground power lines? If yes, why doesn't it work?

This is just some compatibility code to load savegames when objects are missing. The powerlines are ok, but the tunnel is missing, it is replaced with a road tunnel. Do not touch it.

Thank you, this works for the crashy label. The strange one next to it it still there, but causes no problems.

What is strange about the label? I could delete both without problems.

[whoami]

As the resulting savegame will still have a defect, wouldn't it be more useful to remove the tunnel with the objects inside it (here: generator)?

Labels: OK.