Author Topic: Provisional validation results  (Read 1744 times)

0 Members and 1 Guest are viewing this topic.

Offline Ters

  • Coder/patcher
  • Devotee
  • *
  • Posts: 4870
  • Total likes: 202
  • Helpful: 108
  • Languages: EN, NO
Provisional validation results
« on: March 07, 2013, 06:49:51 AM »
The last few days, I have been working on a validation tool for pak sets. So far, it's found the following "errors" in pak64. Not all are necessarily unwanted, but simply openings for add-ons to fill. However there are a few that looks like plain errors, such as conflicting constraints and the likely typo in the introduction date for AdlerPersonenwagen. (There might be some errors in this error report, but I've checked some of them, and the complaints seem valid. Especially the "pull validator" is tricky to get right.)
ErztrailerBefore constraint can not be fulfilled between 1961-02 and 1961-04
HolztrailerBefore constraint can not be fulfilled between 1961-02 and 1961-04
TPBeiwagenAfter constraint references vehicle TPBeiwagen that has conflicting before constraint
CombinoShortB(Mc)After constraint references vehicle CombinoShortA(Mc) that has conflicting before constraint
AutotrailerBefore constraint can not be fulfilled between 1961-02 and 1961-04
BuchtrailerBefore constraint can not be fulfilled between 1961-02 and 1961-04
EinheitsTenderBefore constraint references vehicle BR38 that has conflicting after constraint
CementtrailerBefore constraint can not be fulfilled between 1961-02 and 1961-04
Ox4Powered vehicle has nothing to pull between 0001-01 and 1400-01
PferdebahnPowered vehicle has nothing to pull between 1865-01 and 1865-05
PferdebahnPowered vehicle has nothing to pull between 1932-01 and 1935-01
Ox2Powered vehicle has nothing to pull between 0001-01 and 1400-01
HorsesPowered vehicle has nothing to pull between 0001-01 and 1400-01
AdlerPersonenwagenNothing to pull this vehicle between 1825-08 and 1835-08
AdlerPersonenwagenNothing to pull this vehicle between 1857-06 and 1863-01
HolzwagenNothing to pull this vehicle between 1857-06 and 1863-01
PrPersonenwagenNothing to pull this vehicle between 1857-06 and 1863-01
old_open_carNothing to pull this vehicle between 1857-06 and 1863-01
PrPostwagenNothing to pull this vehicle between 1857-06 and 1863-01
BoxcarNothing to pull this vehicle between 1857-06 and 1863-01
StonequarryIntroduced in 0001-01, but no consumer until 1919-01
SandquarryIntroduced in 0001-01, but no consumer until 1919-01
KohlegrubeIntroduced in 1810-01, but no consumer until 1871-01
cow_farmIntroduced in 1900-01, but no consumer until 1920-01

Offline prissi

  • Developer
  • Administrator
  • *
  • Posts: 8823
  • Total likes: 323
  • Helpful: 229
  • Languages: De,EN,JP
Re: Provisional validation results
« Reply #1 on: March 12, 2013, 04:13:24 PM »
Thank you for your check. The intro dates of source producers are based on their function/appearance, not on the end consumer date (in order to allow for other factory chains of reusing them).

The adler stuff is made also for the rocket (which is in the set only as a source at the moment). The gap in the engine timeline is due to nobody did edit the renders of Raven yet. There are actually quite some engines to choose, but with annoying extra pixels in some views.

The slight delay between some intro dates of trailers and their vehicles is to avoid too many intro messages at the beginning of a month. Thus it heralds when construction (for instance) a tram track would start to make sense.

The before conflicting after seems to be wrong. The Einheitstender as well as the Beiwagen or the Combino work as intended.

Offline Ters

  • Coder/patcher
  • Devotee
  • *
  • Posts: 4870
  • Total likes: 202
  • Helpful: 108
  • Languages: EN, NO
Re: Provisional validation results
« Reply #2 on: March 12, 2013, 05:19:10 PM »
The before conflicting after seems to be wrong. The Einheitstender as well as the Beiwagen or the Combino work as intended.
I double-checked these, and unless there is an error in my pak file reader, the errors are real. However, these errors are not apparent inside the game, since the game follows the most restrictive constraints (it checks both ways). In detail, the errors are as follows, and all of them are caused by asymmetric constraints.
  • Einheitstender requires one of several locomotives in front of it, including BR38. However the constraints on BR38 allows only BR38-Tender after it. I think BR38 also used to allow Einheitstender, but the constraint for BR38 was changed, but not those of Einheitstender.
  • The constraints for TPBeiwagen allows another TPBeiwagen to be attached after it. However, TPBeiwagen can only attached after TPSchienenbus, not another TBBeiwagen.
  • The end unit of a combino allows another front unit behind it (ie. that several sets are couble together), but the start unit can only be first vehicle in a "convoi".