Game hangs on loading with current experimental

[neroden]

So, yeah, a lot of work necessary before you can consider releasing this.

I emailed the saved game to you.

[jamespetts]

Thank you for the report. The problem here is that you seem to have saved a game in one of the intermediate sets of commits in which there was an incomplete set of changes to the saved game file format. This should not happen any longer on the 11.x branch.

To get this to load, use the 11.x branch, and comment out the following code:

Code Select Expand


if(file->get_experimental_version() >= 11 && file->get_version() >= 112003)
{
file->rdwr_long(max_axle_load);
file->rdwr_long(max_convoy_weight);
}


When the game is re-saved, it will be saved as 112002, so these parameters will no longer be present.

[neroden]

Fixed the file and emailed you.  Freight station coverage is still completely broken in multiple ways, and I would STRONGLY suggest ripping the feature out and starting fresh from a known-working codebase.  There is no point in trying to patch a feature which was implemented wrong; if you back out all the broken bits it will make it a lot easier for us to come up with a way to implement it correctly.

Something else has also broken routing of freight entirely (the "unknown to unknown" bug).  I have now given you a solid example file.  I suspect this was broken by the walking features in one way or another, clearly in a part of the code you haven't spotted.  You might be able to find this without having to back the code out... it doesn't seem as broken as the freight station coverage.

[prissi]

I am not sure the could be introduced by the merge from standard, where the routing is deferred until a convoi actually changes something at a station. In this case standard (if nothing previously got the same way) would show unknown. That would obviously not needed on experimental due to different routing.

[neroden]

This probably wasn't introduced by the merge from standard, mostly because I think we haven't merged that code yet --  I've been merging a few commits at a time, and debugging them, rather than trying to merge everything at once.

However, thanks for the warning, Prissi, I'll watch for that when it comes up.