News:

Simutrans Sites
Know our official sites. Find tools and resources for Simutrans.

2 fixes for fabrikbauer

Started by eipi, October 26, 2013, 07:00:50 PM

Previous topic - Next topic

0 Members and 1 Guest are viewing this topic.

eipi

This patch fixes 2 issues in fabrikbauer_t:

  • The old besch should be deleted if another one with the same name is registered
  • increase_industry_density(): ignoring climates did not work correctly

Dwachs

thank you, nice spotted! Deletion of besch-pointers does not make much sense, as these besch classes lack proper destructors, that said, no child nodes will be deleted.
Parsley, sage, rosemary, and maggikraut.

eipi

Oh ok, I just thought it was consistent with how brueckenbauer_t (etc.) handle duplicated beschs.
But the bug in increase_industry_density() is really a bug, though, I just double checked  ;)

Dwachs

you are right - in r6860 (including delete old besch and correct spelling)
Parsley, sage, rosemary, and maggikraut.