The International Simutrans Forum

 

Author Topic: Extract world speed record management into its own class  (Read 1096 times)

0 Members and 1 Guest are viewing this topic.

Offline ArthurDenture

  • Coder/patcher
  • *
  • Posts: 86
Extract world speed record management into its own class
« on: September 08, 2013, 04:05:48 AM »
I noticed that world speed record management in simworld.cc was pretty self-contained, so I wrote up a patch to move it into its own class. See attached.

It's not a huge win, but it's still a nice small improvement: several dozen lines of code and some member variables are removed from simworld.cc.

Offline prissi

  • Developer
  • Administrator
  • *
  • Posts: 10822
  • Languages: De,EN,JP
Re: Extract world speed record management into its own class
« Reply #1 on: September 08, 2013, 10:20:09 PM »
Why not, incorporated.

Offline ArthurDenture

  • Coder/patcher
  • *
  • Posts: 86
Re: Extract world speed record management into its own class
« Reply #2 on: September 08, 2013, 10:51:10 PM »
It looks like you might have forgotten an "svn add" on the two new files...

(On the plus side, http://ec2-54-242-171-11.compute-1.amazonaws.com/jenkins/job/simutrans/ caught this :-).)

Offline Markohs

  • DevTeam, Coder/patcher
  • Devotees (Inactive)
  • *
  • Posts: 1559
  • Languages: EN,ES,CAT
Re: Extract world speed record management into its own class
« Reply #3 on: September 09, 2013, 09:10:59 AM »
Yep, dataobj/records.* is not on svn, prissi

EDIT: Just uploaded them myself @6695, I hope prissi doesn't mind. I also restored the three slashes comments in the .h world records, that way the comments appear in doxygen, you turned them to two slashes, I hope you don't mind it either. :)
« Last Edit: September 09, 2013, 09:20:53 AM by Markohs »