News:

The Forum Rules and Guidelines
Our forum has Rules and Guidelines. Please, be kind and read them ;).

Extract world speed record management into its own class

Started by ArthurDenture, September 08, 2013, 04:05:48 AM

Previous topic - Next topic

0 Members and 1 Guest are viewing this topic.

ArthurDenture

I noticed that world speed record management in simworld.cc was pretty self-contained, so I wrote up a patch to move it into its own class. See attached.

It's not a huge win, but it's still a nice small improvement: several dozen lines of code and some member variables are removed from simworld.cc.

prissi


ArthurDenture

It looks like you might have forgotten an "svn add" on the two new files...

(On the plus side, http://ec2-54-242-171-11.compute-1.amazonaws.com/jenkins/job/simutrans/ caught this :-).)

Markohs

Yep, dataobj/records.* is not on svn, prissi

EDIT: Just uploaded them myself @6695, I hope prissi doesn't mind. I also restored the three slashes comments in the .h world records, that way the comments appear in doxygen, you turned them to two slashes, I hope you don't mind it either. :)