The International Simutrans Forum

 

Author Topic: [nightly] Default value of loading_time for older paks  (Read 2055 times)

0 Members and 1 Guest are viewing this topic.

Offline z9999+

  • Coder/patcher
  • *
  • Posts: 377
[nightly] Default value of loading_time for older paks
« on: November 03, 2013, 07:55:21 AM »
In vehikel_besch.h: loading_time = 1000;
In vehikel_writer.cc: uint16 loading_time = obj.get_int("loading_time", 1000 );

but...

In vehikel_reader.cc: if(version<9) { besch->loading_time = 1800; }

Why default value of loading_time for older paks is different ?

Offline prissi

  • Developer
  • Administrator
  • *
  • Posts: 9585
  • Languages: De,EN,JP
Re: [nightly] Default value of loading_time for older paks
« Reply #1 on: November 03, 2013, 09:19:59 PM »
That shoudl be indeed corrected. Thank you.

Offline z9999+

  • Coder/patcher
  • *
  • Posts: 377
Re: [nightly] Default value of loading_time for older paks
« Reply #2 on: November 13, 2013, 12:31:05 PM »
Thank you.

So, by default, if 10 coach train unload full capacity passenger and load full capacity passenger in one step, wait_lock will be 10*(1000ms+1000ms)=20sec. It was always 2sec in previous versions.
Is this correct ?

Offline prissi

  • Developer
  • Administrator
  • *
  • Posts: 9585
  • Languages: De,EN,JP
Re: [nightly] Default value of loading_time for older paks
« Reply #3 on: November 13, 2013, 01:48:59 PM »
Yes, that is true. One my change it for the longest time of a single car, if this is preferred. Any input is welcomed.

Offline kierongreen

  • Dev Team, Coder/patcher
  • Devotee
  • *
  • Posts: 2269
Re: [nightly] Default value of loading_time for older paks
« Reply #4 on: November 14, 2013, 12:24:45 AM »
I would say go for single longest time rather than total. Just because a train is twice as long doesn't mean it takes twice as long to load.

Offline prissi

  • Developer
  • Administrator
  • *
  • Posts: 9585
  • Languages: De,EN,JP
Re: [nightly] Default value of loading_time for older paks
« Reply #5 on: November 14, 2013, 09:08:07 PM »
Any goods train will take twice as long for unlaoding with the double number of cars, though.

Offline kierongreen

  • Dev Team, Coder/patcher
  • Devotee
  • *
  • Posts: 2269
Re: [nightly] Default value of loading_time for older paks
« Reply #6 on: November 14, 2013, 11:37:21 PM »
Would it be overly complicated for players if passenger trains behaved differently from goods?

Offline prissi

  • Developer
  • Administrator
  • *
  • Posts: 9585
  • Languages: De,EN,JP
Re: [nightly] Default value of loading_time for older paks
« Reply #7 on: November 15, 2013, 12:05:17 AM »
No, but confusing. One should rather set the time accordingly for passenger trains.

Offline Ters

  • Coder/patcher
  • Devotee
  • *
  • Posts: 5558
  • Languages: EN, NO
Re: [nightly] Default value of loading_time for older paks
« Reply #8 on: November 15, 2013, 06:09:10 AM »
Any goods train will take twice as long for unlaoding with the double number of cars, though.
Really? It might, but that depends on the layout and equipment available at the loading/unloading site. Bulk trains are probably more linear in how (un)loading time scales with length, but intermodal trains can have a constant (un)loading if they just put a corresponding number of cranes and/or reach stackers to work on it.

However, it's best not to overcomplicate things.