News:

The Forum Rules and Guidelines
Our forum has Rules and Guidelines. Please, be kind and read them ;).

[patch] Marker window

Started by z9999, January 19, 2009, 07:16:08 PM

Previous topic - Next topic

0 Members and 1 Guest are viewing this topic.

z9999

New marker window with player color.
This include some fixes which don't match with label_t well.

Fixed these bugs:
- Marker changed the owner of cityroad and city buildings
- text_farbe() didn't return the color of marker owner
- Couldn't delete marker on station

Changed:
- Color of title bar is player color
- Marker list buttons have the color of marker owner
- Clicking marker list buttons don't close marker window
- Changing player close marker window

[edit] updated patch for some old games

[edit2] removed this patch. please use new one.

[attachment deleted by admin]


z9999

Quote from: Frank on January 19, 2009, 07:28:56 PM
Marker list add List tools?

Maybe, not.
This is still not a normal list window.
When you clck ok/remove/cancel button, window will close.

I don't know the safety way to update list.
If someone can do it, please do so.

prissi

Very good work on this.

I agree to FrankP taht all marker should be listed as stops, convois, ... player specific. And adding marker should be a special tool, and removal with the standard removal tool, as many players. The current marker system is quite hackish.

z9999

All new.
This contains some bug fixes.

To build a new marker:
- Click old marker icon on toolbar
- Click land with this tool
- A new marker info window will open, input text and hit "enter/return" key

I used wkz_marker_t for this. So, old marker window don't open anymore, sorry.

To change marker text:
- Click your marker with inspection tool
- A marker info window will open, change text and hit "enter/return" key

Yor can't change the text of other players, any more.

To remove marker text:
- Click your marker with remover tool

Removing priority is the first.

New Marker list window: dialog_tool[25]

Order: Name, Koord, Player
Filter: Active player only, Show all players

Well, we often use a marker to notice something to other players.
So, I added this filter. Default is "Active player only".


Fixed these bugs:
- Marker changed the owner of cityroad, groundobj and city buildings
- text_farbe() didn't return the color of marker owner
- Couldn't delete marker on station
- Couldn't delete marker if other player's object was build on it


[attachment deleted by admin]

prissi

Great, will test it and then include it.

VS

After this improvement, I may use marker tool, too :)

My projects... Tools for messing with Simutrans graphics. Graphic archive - templates and some other stuff for painters. Development logs for most recent information on what is going on. And of course pak128!


IgorEliezer

*claps*

Big improvement.

I liked to use markers when when I wanted to give names to districts and neighborhoods in metropolises. I'd like too see how it'll work out now.

VS

How do I delete a marker?

Maybe a button on the info window?

My projects... Tools for messing with Simutrans graphics. Graphic archive - templates and some other stuff for painters. Development logs for most recent information on what is going on. And of course pak128!

jamespetts

Quote from: IgorTekton on January 21, 2009, 03:02:26 PM
*claps*

Big improvement.

I liked to use markers when when I wanted to give names to districts and neighborhoods in metropolises. I'd like too see how it'll work out now.

Perhaps, for that function, use the public player?
Download Simutrans-Extended.

Want to help with development? See here for things to do for coding, and here for information on how to make graphics/objects.

Follow Simutrans-Extended on Facebook.

Combuijs

QuoteHow do I delete a marker?

QuoteTo remove marker text:
- Click your marker with remover tool

Seems quite logic to me...  ;)
Bob Marley: No woman, no cry

Programmer: No user, no bugs



VS

I must learn to read again. That's the university, powerpoint everywhere... ;)

I agree that this is great improvement! Thanks!

My projects... Tools for messing with Simutrans graphics. Graphic archive - templates and some other stuff for painters. Development logs for most recent information on what is going on. And of course pak128!

gerw

It would be nice, if the input box for text of marker directly gains the focus when placing a marker.