Started by DrSuperGood, July 06, 2014, 01:41:01 AM
0 Members and 1 Guest are viewing this topic.
Quote from: prissi on October 18, 2014, 09:01:24 PMDid somebody other tested this? I think it is very interesting, but in the last two months I lacked serious time for in-depth testing.
Quote from: Vladki on October 19, 2014, 09:44:28 AMYou may try what I suggest in the long distance patch thread: add "dialog_tool=,~" in menuconf.tab.Then you will be able to change to JIT2, but you may run into the same bugs as I did.
QuoteI have managed to find a reproducible bug. Look at https://uran.webstep.net/~vladki/simutrans/, download the autosave07.sve and addons.zip - it is my savegame converted to jit2 - run it with pak128.Britain 1.14 (last single-height stable) and some recent nightly.It will be loaded close to two stell mills, one wil be quickly recovering from buggy undersupply (demand -200 or so). Then you can watch the steel demanding industries slowly restart production and waiting steel trains to leave the station. When you load the game there are a few trains waiting for cargo, but when the steel is produced at full, at most one train shall be waiting for cargo.Then let the game running for a while and move to the other end of map - find car dealer in Christminster. Normally it should be selling some 260 cars/month. (max with power boost is 320). It will slowly recover production. But the trains can deliver 60 cars at once, while the input storage of this shop is only 53. So it happens from time to time that the 7 extra cars are thrown away, and deduced from demand. I am not sure if that is the trigger for the bug. If you run the game until august around 20:00 (in game time), the demand buffer of this car dealer gets quickly satisfied by the car factory and drops to -4, never to rise again. There are still some cars on the way, but they are consumed without increasing the demand counter. It drops even more as some of the supplies overcrowd the dealer. On september 3:00 the last delivery happens, and car dealer is not ordering any more.
QuoteThose "bugs" were what I was talking about. They would cause my test to fail. (They are not really bugs, because they are a known effect of doing somewhing JIT2 doesn't support.)
QuoteI think I will try to relase a stable (or rc) this week and then commit it afterwards. Just if there is some effect with server games, there is a somewhat stable (which is lacking at the moment).
Quote from: prissi on November 16, 2014, 12:08:16 AMThis weekend I will relase 120.0.1 and then the new JIT can be incorporated. Just waiting for the nightly mac builds.
QuoteNo, he refers to whatever revision when mac builds get back working, then prissi will release and JIT will be incorporated.
Quote from: DrSuperGood on November 16, 2014, 05:34:10 PMIn fact the last nightly for all 3 was built earlier today.
Quote from: DrSuperGood on November 16, 2014, 05:34:10 PMare you saying that there is an error in the Mac builds currently preventing them from running (not building as that appears to be working fine)?
QuoteShould it be enough to determine the type of a factory once instead on every steps?
QuoteFor single and multiple consumer/factory procuder: COuld this logic be not joined. The overhead seems rather small compared to the huge repetitive case construct.
QuoteSorry, editing took so long. See about the error with amount at factory. Maybe scaling of some factors had some side effect in displaying.
QuoteI think in order to get compatibility the type needs to be either calculated onload of the besch of taken directly from it. SO I would suggest to move this logic to factory_reader. (Or I can do it myself, if you like).
QuoteAbout joining logic. THat is much better, because if there are typos/errors, then you do not have to maintain almost the same code twice. Reusing is really helpful.
QuoteThe display seems off; upon loading an old game (i.e. the pak 64 steel mill) then the number in ore are half and coal are twice the value. YOu see that when a truck with 42 tons of coal arrives the dispolay increases to 84 tons.
(uint32)(0.5 + (double)ausgang[index].menge * (double)(besch->get_produkt(index)->get_faktor()) / (double)(1<<(fabrik_t::precision_bits + DEFAULT_PRODUCTION_FACTOR_BITS))),
(sint32)(0.5+ausgang[index].menge / (double)(1<<fabrik_t::precision_bits)),
Quote from: Vladki on November 26, 2014, 09:48:53 PMDo I understand it right that the JIT2 is in latest nightlies?
QuoteLook for paper mill at (90,3).