[idea] Auto signal building

[gauthier]

when it will be implemented ?

[gerw]

but what about the marker used for station coverage??

Internally this isn't managed as an image, so it can't be used.

and what about using the signal cursor instead of the bulldozer?

I think, this will cause confusions, since the signal cursor looks like a signal itself.

[z9999]

One problem:

1. Click on track with CTRL key
2. Click on bare ground

In this case, first zeiger will disapper but first click is not canceled.
So, next click will became second click.
This behavior is different from way tools.

[gerw]

Thank you, z9999. It is fixed now.

[gerw]

New version against r2329.

[spm]

HOW TO USE .patch?

[Dwachs]

You have to compile simutrans yourself to be able to apply patch files:

Get the source code first. Compile it.

Then you can use TortoiseSVN -> Apply patch (Windows) or the 'patch' command (under Linux).

If no conflicts arise, compile again.

[jamespetts]

Hmm, I'd forgotten all about this. This might be worth including in Simutrans-Experimental, once I have the new revenue model worked out.

[jamespetts]

I am in the process of incorporating this into the next release of Simutrans-Experimental: I must say - it works very well. It really does make the player's job a great deal easier. Thank you, Gerw, for the excellent work :-)

[jamespetts]

This has now been included in the latest version of Simutrans-Experimental.

[prissi]

did you still have this for testing?

[gerw]

I've uploaded it at tu-chemnitz.de/~gerw/patches/auto_sign_r2530.patch. I didn't test, whether it complies, I'm too tired now... I also have to update it with respect to the two_click_tool.

Edit:
We can't define this as a two_click_werkzeug, since it works a little bit different. A simple click should place a signal like in current implementation. But a two_click_werkzeug will start the route at the first click.

[Dwachs]

Does this patch work as intended in simutrans experimental? I ask, since I have tried to get this work by applying the diff. Everytime I move the mouse over a tile with an way the tool marks it as its start so I patched the patch (updated diff attached).

I will try to get this implemented as a two-click tool, that its behavior is more consistent with the other click-and-drag tools. And it needs to be changed for the network mode.

However, I am not that satisfied with the overall behavior of the auto-signal tool.

When should the dialogue appear? Everytime one uses the tool? Never (and use a value from simuconf.tab)?

What happens if one accidentally builds masses of signals? Or signals with wrong directions?

Deleting of signals could be done with checkbox 'delete signals' in the gui. Or setting the signal space large enough and select 'remove intermediate signals'

[jamespetts]

Dwachs,

it is indeed broken in Simutrans-Experimental 7.1, and was even more broken after integrating the network code in the latest -devel (proto-7.2). Bernd has spent a lot of time working on it to try to fix it - I fear that there has been some duplication of effort! This does look like the sort of thing that ought to be in Standard, though.

[prissi]

Appearance could be like the station layout dialoge: only with control key.

[z9999+]

When I tested original version before, it worked with signal, long block signal and choose signal.
But it didn't work with presignal.
(Presignal has only presignal bit.)

I don't use this feature with presignal, long block signal or choose signal.
So, it was not a problem for me but....

[Dwachs]

Dwachs,

it is indeed broken in Simutrans-Experimental 7.1, and was even more broken after integrating the network code in the latest -devel (proto-7.2). Bernd has spent a lot of time working on it to try to fix it - I fear that there has been some duplication of effort! This does look like the sort of thing that ought to be in Standard, though.

So then dont waste your time on this. If you have any other question about network mode, let me know. I would be glad to help.

I thought of the following implementation:
1) one click with mouse: place signal as it is now
2) click-and-drag: work like building overheadlines now (mouse button is not released)
3) ctrl-click: trigger the dialogue then activate the dragging mode

After the first click in 2 and 3 preview images are shown as with overheadlines, with second click the signals are built. In networkmode it is not possible to open the dialogue after the second click.

2) takes the configuration from the last call of the tool (or maybe from a tab file), if no valid data is there, then open the dialogue

2) cannot work in networkmode as the first click is not transfered (when the mouse button is not released)

[prissi]

2) should be able to work in networkmode, since normal preview works too ... The building should only done after release, or?

[Dwachs]

2) should be able to work in networkmode, since normal preview works too ... The building should only done after release, or?

But normal waybuilding does build on the first click. In networkmode mode, only the work commands are sent, which means after releasing the button. So click-drag-release cannot work (currently) over networkmode and is deactivated there.

[Dwachs]

Here is an update. Not network compatible up to now.

[jamespetts]

It would be excellent if this was incorporated into Simutrans-Standard! This really does make signal building a great deal easier.

[Dwachs]

Update. It should now work also in network mode.

Usage:

1) ctrl-click on icon to get the dialogue with the space settings
2) click-and-drag to place multiple signals (these will be placed after mouse button is released); does not work in network mode
3) ctrl-click (and release) on a way tile to start the dragging - use this in network mode

[prissi]

MAybe there should be rather two different tools to avoid confusion for fast mousehandler to avoid placing unwanted signals when click on a border between two lines. OTherwise it would built many signals unintentianally.

[Dwachs]

updated the patch.

I added an additional check to prevent building of many signals by clicking on a tile border.

[Dwachs]

incorporated in rev 3830. New help file: signal_spacing.txt. See attachment.

Edit: help file already imported into simu-translator.

[Dwachs]

Topic splitted: compile problems with makeobj are in :

http://forum.simutrans.com/index.php?topic=6019.0

[sanna]

incorporated in rev 3830. New help file: signal_spacing.txt. See attachment.

Edit: help file already imported into simu-translator.

I find the help text easily enough in SimuTranslator, but I am having problem locating the strings in the dialogue themselves... (signal spacing, remove interm. signals, replace other signals and set signal spacing) Are they available for translation?

[Dwachs]

In principle yes, but they are not added yet in the translator.

Edit: strings are added.

[sanna]

It seems to me that the tool does not respect the directionality of existing signals. Could it be modified to do so?

F ex when adding more signals to allow more trains to queue up at a "meeting stretch" I usually start by placing oneway signals with the correct direction set on the "exit spur" at each end. However, then using the signal spacing tool gave me signals with no directionality set, forcing me to go over each signal individually to set the correct direction... then the time I saved using the tool was extremely small.. .*smile*

[Dwachs]

Hm. For me it places one-way signals exclusively. This is also the intention of the incorporated patch.

You got a lot of bi-directional signals?

[sanna]

Yes I did, maybe I did something wrong when building?

EDIT: Trying to reproduce, but failing... It is a bit odd for which direction the signals are placed, but I will get used to it. If I see it again, I will report back, but in the meantime consider it a non-problem!

EDIT 2: I modified the English help text adding the line: ''Signals will be built allowing trains to pass only in the direction you dragged the mouse.'' Please inform me if this is not correct.

[Dwachs]

EDIT 2: I modified the English help text adding the line: ''Signals will be built allowing trains to pass only in the direction you dragged the mouse.''

This is correct. (if no bugs are there ...)