The International Simutrans Forum

 

Author Topic: New facotry smokes  (Read 4851 times)

0 Members and 1 Guest are viewing this topic.

Offline Vladki

  • Devotee
  • *
  • Posts: 3437
    • My addons, mostly roadsigns, pak128.cs
  • Languages: EN, CS
Re: New facotry smokes
« Reply #35 on: April 02, 2020, 06:33:18 PM »
Rotations backported, pull request created. https://github.com/jamespetts/simutrans-extended/pull/151/files

But as written in the comment: It started by the weird condition in simobj.cc, where objects with xoff=0 were not affected at all, which broke the smoke rotations. But removing that condition broke bridges, and required a fix in bruecke.cc, pillar.cc and wayobj.cc. Unfortunately it is possible that some more objects will be affected by this. Nobody knows why that weird condition xoff=0 was put in place.

Offline jamespetts

  • Simutrans-Extended project coordinator
  • Moderator
  • *
  • Posts: 20266
  • Cake baker
    • Bridgewater-Brunel
  • Languages: EN
Re: New facotry smokes
« Reply #36 on: April 10, 2020, 01:49:57 PM »
Thank you for this. Can I check what is intended with the branches here: we have a smoke-improvements branch and a smoke-prissi branch. Are they intended both to be merged into the master branch, or only one of them? The smoke-prissi branch does not seem to have anything relating to new smoke parameters: just the rotation fixes.

Offline Vladki

  • Devotee
  • *
  • Posts: 3437
    • My addons, mostly roadsigns, pak128.cs
  • Languages: EN, CS
Re: New facotry smokes
« Reply #37 on: April 10, 2020, 02:16:35 PM »
smoke-improvements branch is to be discarded.

The smoke improvements that have been implemented in standard are different from my proposal.
I will backport them to the smoke-prissi branch. I was just waiting for makeobj compilation to be fixed.
Stay tuned.

(and pakset fixes will follow)

Offline jamespetts

  • Simutrans-Extended project coordinator
  • Moderator
  • *
  • Posts: 20266
  • Cake baker
    • Bridgewater-Brunel
  • Languages: EN
Re: New facotry smokes
« Reply #38 on: April 15, 2020, 11:20:40 AM »
Splendid, thank you: do let me know when this is ready for me to look at.