Started by ACarlotti, May 06, 2018, 12:08:01 PM
0 Members and 2 Guests are viewing this topic.
Quote from: Roboron on February 17, 2022, 11:13:16 AMChanging windows-latest to windows-2019 in the CI fix it. For some reason it is not able to find MSVC in windows-2022.
Quote from: ceeac on February 16, 2022, 07:18:11 PMPull request #503 incorporates the "Heavy Mode" desync debugging mode and some fixes regarding desyncs. Hopefully there should be fewer of them now, but I could not test absolutely everything. Please check before merging the changes because the savegame version is increased.EDIT: Windows CI is failing because
$ make -j3Makefile:777: *** missing 'endif'. Stop.
Quote from: Ranran on February 01, 2022, 12:27:13 PMPull request #485 is for standard's commits r9872 to r10076 related to translator and symsys coordination. and unification of formatting with standard, also translation from amber to yellow.
gui/trafficlight_info.cc: In constructor 'trafficlight_info_t::trafficlight_info_t(roadsign_t*)':gui/trafficlight_info.cc:42:27: error: 'class roadsign_t' has no member named 'get_ticks_yellow_ns'; did you mean 'get_ticks_amber_ns'? 42 | amber_ns.set_value( s->get_ticks_yellow_ns() ); | ^~~~~~~~~~~~~~~~~~~ | get_ticks_amber_nsgui/trafficlight_info.cc:48:27: error: 'class roadsign_t' has no member named 'get_ticks_yellow_ow'; did you mean 'get_ticks_amber_ow'? 48 | amber_ow.set_value( s->get_ticks_yellow_ow() ); | ^~~~~~~~~~~~~~~~~~~ | get_ticks_amber_owgui/trafficlight_info.cc: In member function 'void trafficlight_info_t::update_data()':gui/trafficlight_info.cc:110:32: error: 'class roadsign_t' has no member named 'get_ticks_yellow_ns'; did you mean 'get_ticks_amber_ns'? 110 | amber_ns.set_value( roadsign->get_ticks_yellow_ns() ); | ^~~~~~~~~~~~~~~~~~~ | get_ticks_amber_nsgui/trafficlight_info.cc:111:32: error: 'class roadsign_t' has no member named 'get_ticks_yellow_ow'; did you mean 'get_ticks_amber_ow'? 111 | amber_ow.set_value( roadsign->get_ticks_yellow_ow() ); | ^~~~~~~~~~~~~~~~~~~ | get_ticks_amber_owmake: *** [common.mk:55: simutrans/gui/trafficlight_info.o] Error 1make: *** Waiting for unfinished jobs....
Quote from: jamespetts on February 19, 2022, 11:51:04 AMalso translation from amber to yellow.
Quote from: Ranran on February 19, 2022, 12:27:10 PMOh, I'm so sorry.In standard, this was implemented as yellow, but in extended, I think there may have been a history of it being intentionally made into amber, which is why I revert it a few days ago. The cause is that the revert is clearly incomplete. I apologize for the lack of confirmation.Can I ask what the color notation should be?
Quote from: jamespetts on February 19, 2022, 12:51:05 PMFor traffic lights, the colour should be "amber"
Quote from: Ranran on February 19, 2022, 01:28:10 PMThank you for the clarification. I think I have restored it and now it is testable.
Quote from: jamespetts on February 19, 2022, 11:37:36 AMI am afraid that I am still getting the same error:
Quote from: ceeac on February 19, 2022, 02:00:14 PMCould not reproduce. I have now rebased the branch onto the current master branch to resolve the merge conflict and the issue does not occur there for me either (commit 6c60afa91).
Quote from: jamespetts on February 19, 2022, 03:32:30 PMgames saved in the latest master can't be opened in the heavy mode branch
Quote from: jamespetts on February 19, 2022, 03:32:30 PMand vice versa.
Quote from: ceeac on February 19, 2022, 04:48:41 PMThat was a bug and should be fixed now.That is not a bug because the save game version is incremented in the heavy mode branch.
Quote from: Ranran on February 19, 2022, 11:39:07 PMThere seems to be a problem in compiling with MSVC, because the current changes for heavy mode have not been applied to MSVC. I was able to add the file specification and compile on my own (I just added a link to the file for debug mode), but I don't know if that's correct because I don't understand the conditions correctly.
Quote from: jamespetts on February 19, 2022, 11:54:33 PMDid you have to add a .cc file to the project? If you did and that solved the problem, then this should be a relatively straightforward fix. Can I ask what file it was that you added?
Quote from: Ranran on February 20, 2022, 12:12:54 AMI had to make at least the following changes to get the build to work on MSVC.https://github.com/Ranran-the-JuicyPork/simutrans-extended/commit/36c9cd51899d71719fa440e14df0b2b521f722ee
Quote from: ceeac on February 20, 2022, 03:00:55 PMProbably different settings (simuconf.tab/settings.xml). Try starting two instances in singleuser mode, I managed to reproduce the desync this way. I have not investigated the root cause of the desyncs yet, though.
Quote from: jamespetts on February 20, 2022, 06:13:12 PMCeeac and Ranran - have either of you altered anything in the commits that went in yesterday that related in any way to an interaction between translation texts and the random number generator?
Quote from: Ranran on February 20, 2022, 10:42:58 PMhttps://github.com/jamespetts/simutrans-extended/commit/b9175ecc95e26bdad924eb3e74d1d696f19bb7a2There are some changes related to translation texts. I'm not sure if that will affect it. Indirect effects, if any.
Quote from: Ranran on February 21, 2022, 10:52:49 AMhttps://github.com/jamespetts/simutrans-extended/blob/36c9cd51899d71719fa440e14df0b2b521f722ee/dataobj/objlist.cc#L1043
QuoteI would strongly suggest to also update simevent.cc, siminteraction.cc and simsys_s2.cc
Quote from: Ranran on April 16, 2022, 12:04:24 PMCurrently identified issue:https://forum.simutrans.com/index.php/topic,21536.msg199838/topicseen.html#msg199838