Started by Ranran, February 23, 2019, 05:04:06 PM
0 Members and 1 Guest are viewing this topic.
Quote from: ACarlotti on February 24, 2019, 04:36:32 AMThe first thing that I want to make clear is that there are two kinds of class - accommodation class and fare class. (There is no fundamental reason for these to share the same set of categories, but for historical reasons they do). Mixing up these two different types of class was the source of a number of bugs that I fixed just over a year ago (my first patches, as it happens). At the time I made a deliberate decision to show what accommodation class passengers were occupying; I now see that this was not always the right decision. (Original thread here)
QuoteThere are two cases to consider here:1. In the vehicle details window, the passengers are currently listed according to the accommodation class they are in. I think it is important to separate them this way - you'd want to know how many passengers were inside a stagecoach and how many were sitting on the roof even if you were charging them the same fare class. Furthermore, with your proposed fix, you would end up with two separate lists of passengers under identical headings.The correct change in this case would be to add the information about the reassigned (fare) class while retaining existing information about the accommodation class.
Quote2. In the convoy information window passengers are currently listed according to their accommodation class. I think I agree that in this case knowing the fare class is more useful than knowing the accommodation class. It might be better to add this as a new sort method, but at the moment I can't see any reason to sum over accommodation classes given that the same accommodation class could mean different things in different vehicles.
QuoteActually, I'm beginning to think that having accommodation spaces in vehicles described in the same terms as passenger wealth levels is probably a mistake - perhaps it would be better to change the code (and extend the dat file format) so that each vehicle has a list of accommodation spaces, each of which has a comfort value, a capacity, a name (so we can actually talk about 3rd class compartments, etc.), and a suggested wealth level. A stagecoach might then have it's capacity categorised as "Inside (High)" and "Outside (Very Low)".This would also allow the removal of a nasty botch I put in the code to retrospectively fix the number of classes in a vehicle. I think such changes could be made fully backwards compatible, and would also lead to a reduction in memory usage (especially if anyone tries introducing a 200 class system). I can go into more detail later once I have more time.
QuoteI do not understand the difference between accommodation class and fare class. Is it different from the wealth of people and the (reassigned) class of vehicles?I opened one of my low class car to very low wealth people, then that car's fare is very low class's.It means, the loaded class type of that vehicle is very low. Speaking of the fare mechanism, Is not it the same as very high wealth people riding high class when there is no very high class vehicle?Am I misunderstanding?
Quote from: Ves on February 24, 2019, 09:48:28 PMI believe that the "accommodation class" is the class that is specified in the dat-file and will not change during the game. If you in game reassign that class to another class one has to keep track of the reassigned class, therefore he calls it "fare class". When James first coded the classes feature, there where no such things in the code as "accommodation class" and "fare class", but ACarlotti came and cleared it up so it is easier to code and less likely to create bugs due to misconceptions..Am I right, ACarlotti?
p_class[i] -> p_fare_class[i] / p_acc_class[i]