The International Simutrans Forum

 

Author Topic: Display authors in more objects  (Read 903 times)

0 Members and 1 Guest are viewing this topic.

Offline Leartin at

  • Devotee
  • *
  • Posts: 1277
  • PAK-DEV P192C
  • Languages: DE, EN
Display authors in more objects
« on: March 02, 2019, 01:09:22 PM »
Pretty simple: Many types of objects don't display who painted/rendered them, and I think they should, wherever possible. Probably not icons or cursors, but anything that can be clicked on to open a dialog about it could contains author information (eg. trees, factories, ways, crossings, townhalls, pedestrians [which, by the way, would probably be offended if they knew they were just "private property"],...)

Offline DrSuperGood

  • Dev Team
  • Devotee
  • *
  • Posts: 2732
  • Languages: EN
Re: Display authors in more objects
« Reply #1 on: March 02, 2019, 07:08:20 PM »
I think that some objects might be missing that information. With the ones that do have it encoding it as a string.

Offline Ters

  • Coder/patcher
  • Devotee
  • *
  • Posts: 5554
  • Languages: EN, NO
Re: Display authors in more objects
« Reply #2 on: March 02, 2019, 09:21:10 PM »
All top-level objects have a name and copyright field. See obj_named_desc_t. Some confusingly apparently have multiple copyright fields in the code, but only one is actually used. (bridge_desc_t does not use the copyright field that it "inherits" from obj_named_desc_t, but the one from the nested skin_desc_t.)

The copyright field is probably less likely to contain anything for object types that do not currently display its contents anywhere. Skimming through pak64, the only types that consistently does not have copyright are goods (small pieces of data that probably doesn't qualify for copyright anyway), way objects (there are only two, so small sample size) and pedestrians. Many types only have very small fractions of objects with copyright, though.

Offline Leartin at

  • Devotee
  • *
  • Posts: 1277
  • PAK-DEV P192C
  • Languages: DE, EN
Re: Display authors in more objects
« Reply #3 on: March 03, 2019, 07:57:00 AM »
I think that some objects might be missing that information. With the ones that do have it encoding it as a string.
Encoding it, yes, but not displaying it. It's best seen with factories and trees, both of which display the author in the editor, but not in the objects dialog.

Offline Dwachs

  • DevTeam, Coder/patcher
  • Administrator
  • *
  • Posts: 4607
  • Languages: EN, DE, AT
Re: Display authors in more objects
« Reply #4 on: March 05, 2019, 10:07:47 AM »
I added these information in r8702 & 8703 to: bridge, tunnel, ways, private car, pedestrian, signal, tree, crossing info windows.

Offline Leartin at

  • Devotee
  • *
  • Posts: 1277
  • PAK-DEV P192C
  • Languages: DE, EN
Re: Display authors in more objects
« Reply #5 on: March 05, 2019, 10:49:47 AM »
Nice!  8) Thank you.

I think townhalls could be another easy one (in the townhall info, not the city info, the one which you need to activate in the settings to even see...)
For factories, perhaps in the details-tab, if that's not too much of a hassle?

Offline Dwachs

  • DevTeam, Coder/patcher
  • Administrator
  • *
  • Posts: 4607
  • Languages: EN, DE, AT
Re: Display authors in more objects
« Reply #6 on: March 05, 2019, 03:58:19 PM »
It's already there: for factories in the details tab, for townhalls in the building info window.

Offline Leartin at

  • Devotee
  • *
  • Posts: 1277
  • PAK-DEV P192C
  • Languages: DE, EN
Re: Display authors in more objects
« Reply #7 on: March 05, 2019, 07:18:54 PM »
Sorry, they did not before and you did not mention them as newly added. Since there are currently no Nightlies, and the latest did not support p192c anyway, I regret I could not fact check before my last post.
But it's great to hear they will be there :D

Online prissi

  • Developer
  • Administrator
  • *
  • Posts: 9584
  • Languages: De,EN,JP
Re: Display authors in more objects
« Reply #8 on: March 08, 2019, 01:18:25 PM »
What is the issue with http://www.simutrans-forum.de/nightly/ ? It seems to build fine for windows and linux

Offline Leartin at

  • Devotee
  • *
  • Posts: 1277
  • PAK-DEV P192C
  • Languages: DE, EN
Re: Display authors in more objects
« Reply #9 on: March 08, 2019, 04:40:10 PM »
I suppose it was this issue that caused nightlies to cease for a while: https://forum.simutrans.com/index.php/topic,18816
Just like the issue with p192c, this was already resolves, so I can see the proper attributions now :D Thanks again.