Started by ceeac, March 12, 2019, 10:27:48 AM
0 Members and 1 Guest are viewing this topic.
Quote from: prissi on March 13, 2019, 06:17:32 AMAlso why is everyone so bent on fixing warnings for GCC?
simhalt.cc:2362:22: warning: unused variable 'woowner' [-Wunused-variable] player_t *const woowner = wo->get_owner(); ^simhalt.cc:2366:19: warning: unused variable 'workcost' [-Wunused-variable] sint64 const workcost = -welt->scale_with_month_length(cost * welt->get_settings().cst_make_public_months); ^simhalt.cc:2353:13: warning: unused variable 'wo' [-Wunused-variable] wayobj_t *wo = NULL;
Quote from: prissi on March 13, 2019, 06:17:32 AM[...] although not all useful. A lot about are loosing precisions due to cast; something GCC is awful silent about.
Quote from: An_dz on June 30, 2019, 10:30:37 PMI've never heard of any compiler that shows a warning for something 'fixed' from a warning of another compiler, though it might have happened in older times.
Quote from: An_dz on June 30, 2019, 10:30:37 PMThat's because we don't pass the flag to check those warnings (-Wconversion).
Quote from: Ters on July 01, 2019, 05:54:46 AMIt may also be that the fix done for the first compiler is implementation dependent, which can even cause the other compiler to actually issue an all out error.
Quote from: Ters on July 01, 2019, 05:54:46 AMI guess it's not part of -Wall because it may not always be possible to tell the compiler that you know something it doesn't that makes it safe.