The International Simutrans Forum

 

Author Topic: Auto UnderGround Mode follow convoi  (Read 20661 times)

0 Members and 1 Guest are viewing this topic.

Offline shingoushori

  • *
  • Posts: 18
  • Languages: JP
Auto UnderGround Mode follow convoi
« on: August 10, 2019, 08:03:04 AM »
Hello
Let me introduce the new extension "Auto UnderGround Mode follow convoi".

if ctrl key pressed with follow convoi button, this mode sets.
This mode is ...
When the convoi which followed enters the underground, it automatically sets the underground mode,
adjusts the height cut level according to the altitude followed in realtime.

and this is the demonstration movie on my exe
https://www.youtube.com/watch?v=-X3NYT2e4Q8

additionally,
I'm sure this my sample codes has concern about performance,
because I focused on the points to realize my ideas when I created, sorry.

I hope you like it. Thanks for reading.

Offline Ranran

  • Devotee
  • *
  • Posts: 1077
  • Languages: ja
Re: Auto UnderGround Mode follow convoi
« Reply #1 on: August 10, 2019, 11:36:50 AM »
(´・ω・`)おほーっ!
(´・ω・`)哇噢!太棒了!
(´・ω・`)Woohoo! FANTASTIC!
(´・ω・`)빵 사이에 햄을 끼워했습니다
(´・ω・`)/Sieg Simutrans!

Offline Leartin

  • Heir-Benevolent-Dictator-Apparent
  • Devotee
  • *
  • Posts: 1464
  • PAK-DEV P192C
  • Languages: DE, EN
Re: Auto UnderGround Mode follow convoi
« Reply #2 on: August 10, 2019, 11:49:16 AM »
(´・ω・`)/Sieg Simutrans!

Please don't.

Offline Matthew

  • *
  • Posts: 353
    • Japan Railway Journal
  • Languages: EN, some ZH, DE & SQ
Re: Auto UnderGround Mode follow convoi
« Reply #3 on: August 12, 2019, 01:59:29 PM »
[EN] This is indeed amazing.

[DE] Wunderbar!

Offline prissi

  • Developer
  • Administrator
  • *
  • Posts: 10031
  • Languages: De,EN,JP
Re: Auto UnderGround Mode follow convoi
« Reply #4 on: August 13, 2019, 01:15:28 PM »
I think this is a sensible default, and should be rather a setting in simuconf.tab, or a visible setting. Usually the follow a vehicle dialogue is seldom used but for making movies. Then toggle a setting in simuconf.tab or a button in a dialogue is not too much effort.

Offline shingoushori

  • *
  • Posts: 18
  • Languages: JP
Re: Auto UnderGround Mode follow convoi
« Reply #5 on: August 25, 2019, 11:41:12 AM »
I am very glad to receive your replies.

Usually the follow a vehicle dialogue is seldom used but for making movies.
Yes, I think so, but that's so fun !!

I think that this modest operability (if ctrl key pressed) is a reasonable scale for this modification.
There is just a good precedent function : start_all_convoys of depot.

Rather, I am the opposite for add this on simuconf.tab and save data.
Because of compatibility, for this level of functionality, it is not my intention ...

Offline DrSuperGood

  • Dev Team
  • Devotee
  • *
  • Posts: 2829
  • Languages: EN
Re: Auto UnderGround Mode follow convoi
« Reply #6 on: August 25, 2019, 06:35:29 PM »
Can we confirm the performance of this with very large maps, e.g. 8,000x6,000? This is to make sure it is not using any legacy underground mode transition code paths which required recalculating graphics for every tile in the map and so suffered performance issues with large maps. If working correctly the transitions should be smooth (instant, as good as no frame drops) even on the largest of maps. I would test myself but due to hardware failure I lack the RAM to test such maps at current.

Offline Ters

  • Coder/patcher
  • Devotee
  • *
  • Posts: 5648
  • Languages: EN, NO
Re: Auto UnderGround Mode follow convoi
« Reply #7 on: August 26, 2019, 12:11:29 PM »
People who use this feature probably switch to underground manually most of the time already, at least I do, so the performance would be the same. While better underground performance would be good, it has got little to do with this feature.

One issue is whether it should be possible to specify full underground or sliced underground. Once this is a setting, one might add "disabled" as well, just in case.

Offline DrSuperGood

  • Dev Team
  • Devotee
  • *
  • Posts: 2829
  • Languages: EN
Re: Auto UnderGround Mode follow convoi
« Reply #8 on: August 26, 2019, 11:43:47 PM »
While better underground performance would be good, it has got little to do with this feature.
If it is not using the smooth transition code a underground transition could freeze the game for 2-8 seconds on very big maps depending on hardware. Hardly a seamless experience.

The code for smooth underground mode changes is already in standard. I was just asking to make sure it is using the code instead of falling back to any legacy code which might not have been removed.

It is currently missing from extended as it has not been back ported yet.

Offline Ters

  • Coder/patcher
  • Devotee
  • *
  • Posts: 5648
  • Languages: EN, NO
Re: Auto UnderGround Mode follow convoi
« Reply #9 on: August 28, 2019, 08:35:45 AM »
If it is not using the smooth transition code a underground transition could freeze the game for 2-8 seconds on very big maps depending on hardware. Hardly a seamless experience.

The code for smooth underground mode changes is already in standard. I was just asking to make sure it is using the code instead of falling back to any legacy code which might not have been removed.
I got mistracked by all the mentioning of checking the performance. Checking for misuse of undead code is done through code review, not performance measurements in my world. As such I assumed that there is only one way to switch to underground (as there should be, unless there are compelling reasons for having one fast-but-glitchy method and one correct-but-slow method), and that it might be considered fast enough when the player explicitly asks for it once in a while, but not for when it might trigger implicitly and repeatedly.

Offline prissi

  • Developer
  • Administrator
  • *
  • Posts: 10031
  • Languages: De,EN,JP
Re: Auto UnderGround Mode follow convoi
« Reply #10 on: October 02, 2019, 04:45:10 AM »
Incorporated with reduced full redraws in -r8832