The International Simutrans Forum

 

Author Topic: [Bug] livery scheme selector list ignores intro month  (Read 826 times)

0 Members and 1 Guest are viewing this topic.

Offline Ranran

  • Devotee
  • *
  • Posts: 1073
  • Languages: ja
[Bug] livery scheme selector list ignores intro month
« on: October 26, 2019, 05:27:12 PM »
     (´・ω・`)Hello.

┏━━━━━━━━━━━━━━━━━━━━┓
┃Ranran appears! らんらんがあらわれた! .┃
┃         ▼          ┃
┗━━━━━━━━━━━━━━━━━━━━┛

I found that livery scheme selector ignores the value of intro_month and creates a list by checking only intro_year.
Although there are options, you have to wait until the actual month of appearance, but the player can not understand anything because we can't check the actual month of livery scheme appearance in the game.

Offline freddyhayward

  • Devotee
  • *
  • Posts: 281
  • Languages: EN
Re: [Bug] livery scheme selector list ignores intro month
« Reply #1 on: October 26, 2019, 10:16:58 PM »
The other issue is that there is no indication as to which livery schemes are applicable to a convoy, leading to endless scrolling through the entire list. The system is virtually inaccessible to new players, and frustrating for experienced players. If I am trying to paint a bus, why are hovertravel and ffestinog railway options?

Offline Spenk009

  • Devotee
  • *
  • Posts: 334
  • Languages: en, de
Re: [Bug] livery scheme selector list ignores intro month
« Reply #2 on: December 19, 2019, 07:24:30 PM »
May I suggest that while this receives attention, that use_timeline also acts on the selection disables the timeline of liveries and enables all? It would make pakset work easier and improve control for players wishing to build outside of timelines.

Offline Vladki

  • Devotee
  • *
  • Posts: 3370
    • My addons, mostly roadsigns, pak128.cs
  • Languages: EN, CS
Re: [Bug] livery scheme selector list ignores intro month
« Reply #3 on: December 20, 2019, 01:26:49 PM »
1. the livery selector combo is obverlapping with list of stops and is thus not usable for direct choose, but only for scrolling
2. it should be limited to liveries that are used by vehicles using the line
3. when picking vehicles in depot, info about available liveries would be very nice.

When speaking about timeline, it would be nice to be able to turn off the timeline only for liveries. However in that case it would be necessary to show not only the livery scheme (like LMS/GWR/BR/Blackpool/Sheffield/...) but a specific livery (BR-Green, BR-Blue, ...). This would be extremely handy in multiplayer games, where players could use liveries to distinguish from other players.

Offline Ranran

  • Devotee
  • *
  • Posts: 1073
  • Languages: ja
Re: [Bug] livery scheme selector list ignores intro month
« Reply #4 on: December 22, 2019, 12:29:27 AM »
I have not yet found the cause of this bug. I suspect that livery scheme list has been updated in the processing of new_year or that the value of intro_month has not been gotten correctly.

The other issue is that there is no indication as to which livery schemes are applicable to a convoy, leading to endless scrolling through the entire list. The system is virtually inaccessible to new players, and frustrating for experienced players. If I am trying to paint a bus, why are hovertravel and ffestinog railway options?
This patch will reduce some annoyance.
I am currently planning to make a patch that like: eliminates the name of the airplane company from inside the bus depot.

Offline Ranran

  • Devotee
  • *
  • Posts: 1073
  • Languages: ja
All livery intro months are ignored
« Reply #5 on: December 23, 2019, 09:50:55 AM »
Subsequent research has shown that the intro month of the "livery" is completely ignored. As a result, the intro month of the "livery scheme" is also ignored. In other words, all intro_month is 1 which is the default value.

For example, according to simuconf.tab and dat settings, if you apply British-Rail for LNER-A1 in 1950, the BR-Early livery will be applied like this:

and it should be green in November 1951, but in January 1951 is already green.

Don't jump the gun!  ::(

Offline Ranran

  • Devotee
  • *
  • Posts: 1073
  • Languages: ja
Re: [Bug] livery scheme selector list ignores intro month
« Reply #6 on: December 29, 2019, 04:59:02 AM »
I think I have identified and fixed the issue where the intro_month for liveries was not registered correctly. This was a simple mistake.
https://github.com/Ranran-the-JuicyPork/simutrans-extended/commit/31b1a57167044f887dee08e3542978228dc3cf97

Please confirm it.
« Last Edit: December 29, 2019, 05:36:29 AM by Ranran »

Offline jamespetts

  • Simutrans-Extended project coordinator
  • Moderator
  • *
  • Posts: 19955
  • Cake baker
    • Bridgewater-Brunel
  • Languages: EN
Re: [Bug] livery scheme selector list ignores intro month
« Reply #7 on: January 18, 2020, 01:08:00 PM »
My apologies: I have realised that I omitted to respond to this thread. I believe that this is now working. Thank you for your fix.