display setting dialog issues

[Ranran]

Thank you for your daily maintenance.
Report multiple small bugs. (´・ω・｀)

(1) hide building setting combobox does not respond to shortcut key changes
For example, hide tree checkbox is sane, but it's not.



(2) The "show nothing" display is incorrect (a colored background is displayed), but as far as I can see in the code, the behavior seems unintended.

Code Select Expand


case 2:
display_outline_proportional_rgb( p.x + LINESPACE + D_H_SPACE, p.y, color_idx_to_rgb(COL_YELLOW), color_idx_to_rgb(COL_BLACK), text, 1 );
display_ddd_box_clip_rgb(         p.x,                     p.y,   LINESPACE,   LINESPACE,   pc-2, pc+2 );
display_fillbox_wh_clip_rgb(      p.x+1,                   p.y+1, LINESPACE-2, LINESPACE-2, pc,   true);
break;
case 3: // show nothing
break;




Also, I think the yellow text color looks better if the vertical alignment is middle.


(3)
display_settings.cc line 104,

Code Select Expand

// add controls to info container
add_table(2,3);

add_table(2,4) is correct. (Although it has no effect in standard, a layout error occurred when adding a table below it in extended.)

[prissi]

Thank you, fixed in r 9242

[Ranran]

* In the display settings dialogue, there appears to be an errant number next to the "show station names" setting (or is this intended? If so, this should be explained in the tooltip)

This was pointed out by James in the incorporating from standard thread.
I was also curious about this display. This looks like a kind of debug display, but it's always visible. Is this intended?

[prissi]

Should be fixed in r9352. Indeed, leftover debug code.