[patch] new cursor movement

[Dwachs]

new patch, selection of all tiles works correctly again.

@z9999: thanks for testing!

@wernieman: could you please make a new spezial build?

[wernieman]

See http://patches.simutrans-germany.com/

[jamespetts]

Very nice! Much easier to use than the standard cursor.

[z9999]

Thank you. It's working well.
A little thing. CTRL operation is not needed in underground mode, is is ?
CTRL is used in 2 cases, building straight road/rail and downgrading road/rail.
If we build a new road/rail in underground mode, ending position is always surface, thus this is not a problem.
But if we want to build a new road/rail from existing road/rail to existing road/rail with CTRL key in underground mode, it might be confused a little, I think.

[prissi]

If not changed, all building in underground is anyway straight connection only.

[Dwachs]

@z9999: you are right with your concerns. Using ctrl-key to select ground AND to build straight is interfering.

What solutions would you (all) prefer?

[jamespetts]

CTRL+SHIFT?

[z9999]

If not changed, all building in underground is anyway straight connection only.

Ahh, yes. I was wrong, I didn't read the code, sorry.

Code Select Expand


if(event_get_last_control_shift()==2  ||  grund_t::underground_mode) {


But, CRTL is still interfering in downgrading road/rail.
Is there any reason not to use SHIFT key ?
SHIFT key was to select topmost and this isn't used anymore.

[Dwachs]

CTRL-key was used to select the topmost way

SHIFT-key seems to be used only in connection with the minimap.

Shall I change the patch to use SHIFT-key to select ground?

[z9999]

Shall I change the patch to use SHIFT-key to select ground?

It is up to prissi.

I changed to following code and seems to be working well.

Code Select Expand


bool select_karten_boden = event_get_last_control_shift() & 1;

But I think other tools also need to change to '& 2' instead of '== 2'.

[prissi]

I am not keen on using an other code, since this functionality for Kartenboden will be possible with the slice mode anyway. Those hidden features make life difficult for most of the peoples. Rather get away from CNTRL at all in the end.

[Spike]

From designers point of view, ctrl and shift are bad ideas, since they are not apparent to new player. Only way to know about these features is by reading the documentation, a thing only few players do.

Simutrans did not have such obscurities originally.

I would ask to rethink the solution, and find a UI that is more accessible to players. I know ctrl and shift sneaked into Simutrans in other places, too, but when I got to know it was already done.

Make features accessible to players. That means either show them their choices, or give clues how to get to other choices.

[z9999]

Then, please remove selecting ground with CTRL key feature.
And also please don't implement this 3d cursor feature until slice mode will be implemented.

[Dwachs]

Patch updated according to your wishes

I hope sliced mode can follow soon.

[prissi]

My suggestion on a transparent ground tile for the top.

[Dwachs]

Nice! I would prefer TRANSPARENT25_FLAG instead of TRANSPARENT50_FLAG in simview.cc. The marked tile is highlighted too heavy imho.

[wernieman]

Should I make a Compilerrun with patch cursor-2437.patch ore new_cursor-r2437-v2.diff?

[Dwachs]

Should I make a Compilerrun with patch cursor-2437.patch ore new_cursor-r2437-v2.diff?

with prissi's new_cursor-r2437-v2.diff. Thank you !!!

[wernieman]

See http://patches.simutrans-germany.com/

[prissi]

This is just a suggestion; maybe the highlighting color should be configurable via simuconf.tab, since the cursor border have different colors in different sets.

[gerw]

In the current version (v2), the orange overlay is drawn above the tool cursor. Can this be changed?

[Dwachs]

in simview.cc  line 184 has to be moved beyond line 195

[gerw]

Ok. Then anybody should do this

[Dwachs]

Updated patch file. The tool cursor is drawn above the orange overlay.

I tested pak64, pak128, pak.german and pak.96. All use an orange marker. So there is no need to change the cursor color. Using player colors (as for station coverage) did not look nice to me.

[z9999]

You forgot pak128.japan, it is blue.
BTW, when I move cursor in underground mode, it shows the object on the ground.
Is this a known problem ?

[prissi]

THis is an error. It was actually intended for bridges ...

[wernieman]

I make a Compilerrun with the lates patch

You found it at  http://patches.simutrans-germany.com/

I named it: sim-*-curser-2437-v3.zip

[Dwachs]

@wernieman: thanks alot! maybe you can remove all older versions from the patch-server?

[wernieman]

Ups .. I forget

[Dwachs]

You forgot pak128.japan, it is blue.

It would be possible to make the overlay color configurable in pak-xyz/simuconf.tab. Preferably using the pre-defined simutrans colors as here:

http://simutrans-germany.com/wiki/wiki/tiki-index.php?page=en_FactoryDef#mapcolor

Any opinions? better suggestions?

[Dwachs]

New patch.

Now the overlay color can be configured in simuconf.tab:

Code Select Expand


# Color of cursor overlay, which is blended over marked ground tiles
# The available colors and their numbers can be found on
#    http://simutrans-germany.com/wiki/wiki/tiki-index.php?page=en_FactoryDef#mapcolor
# Suggested values (155 is the default)
# -- pak64, pak.german, pak128
cursor_overlay_color = 155
# -- pak128.japan
#cursor_overlay_color = 149


If no more bugs are found this patch will go into trunk soon.

[prissi]

I think the cursor color should go to umgebung_t, since this customisation does not affect gameplay. The idea is all gameplay settings into einstellungen (and thus those are transferred in network games) while all visual not engine settings go to umgebung_t.

[Dwachs]

thank you for clarifying

[z9999]

If no more bugs are found this patch will go into trunk soon.

And also please don't implement this 3d cursor feature until slice mode will be implemented.

[Dwachs]

And also please don't implement this 3d cursor feature until slice mode will be implemented.

After integrating the 3d-cursor thing, sliced underground mode will be the next step.