Started by dannyliux, January 01, 2020, 10:27:56 PM
0 Members and 1 Guest are viewing this topic.
Quote from: Ranran on January 30, 2020, 09:04:25 PMMatthew - Thank you for testing and sorry for wasting your time.
QuoteI suppose I have identified the cause and fix. Check it out when you have time and it will help.
Debug: interaction_t::process_event: calling interactive_eventMessage: interaction_t::interactive_event(event_t &ev): calling a toolMessage: tool_query_t(): checking map square 156,17,0Message: tool_query_t(): index 2Debug: convoi::dump(): vehicle_count = 3wait_lock = 0owner_n = 0akt_speed = 153sp_soll = 1072state = 6statename = DRIVINGalte_direction = 2jahresgewinn = 0name = '(1) Hackney horses (pair)'line_id = '0'schedule = '0x555570eb4400'Message: gui_textarea_t::recalc_size(): reset size to 11,0
Message: gui_textarea_t::recalc_size(): reset size to 11,0Thread 1 "simutrans-exten" received signal SIGSEGV, Segmentation fault.0x00005555556bd2b3 in button_t::set_typ (this=0x5555579fbe38, t=button_t::box_state) at gui/components/gui_button.cc:127127 set_size( scr_size(gui_theme_t::gui_button_size.w, max(D_BUTTON_HEIGHT,LINESPACE)) );(gdb) backtrace#0 0x00005555556bd2b3 in button_t::set_typ (this=0x5555579fbe38, t=button_t::box_state) at gui/components/gui_button.cc:127#1 0x00005555556bcf5e in button_t::init (this=0x5555579fbe38, type_par=button_t::box_state, text_par=0x555555a2c720 "Sends the convoi to the last depot it departed from!", pos_par=..., size_par=...) at gui/components/gui_button.cc:74#2 0x00005555556e79b5 in convoi_info_t::convoi_info_t(quickstone_tpl<convoi_t>) ()#3 0x00005555558bb4c6 in convoi_t::show_info() ()#4 0x00005555559c5a41 in vehicle_t::show_info (this=0x5555a5463220) at vehicle/simvehicle.cc:2962#5 0x000055555593d436 in tool_query_t::work (this=0x55555793eea0, player=0x555598aaafc0, pos=...) at simtool.cc:384#6 0x000055555599668a in karte_t::call_work (this=0x55555a38a580, tool=0x55555793eea0, player=0x555598aaafc0, pos=..., suspended=@0x7fffffffb27a: false) at simworld.cc:10155#7 0x0000555555918785 in interaction_t::interactive_event (this=0x55557fc5bf40, ev=...) at siminteraction.cc:240#8 0x000055555591918a in interaction_t::process_event (this=0x55557fc5bf40, ev=...) at siminteraction.cc:417#9 0x00005555559192b1 in interaction_t::check_events (this=0x55557fc5bf40) at siminteraction.cc:439#10 0x0000555555997eab in karte_t::interactive (this=0x55555a38a580, quit_month=2147483647) at simworld.cc:10464#11 0x0000555555926d88 in simu_main (argc=5, argv=0x7fffffffdfd8) at simmain.cc:1382#12 0x000055555593aebc in sysmain (argc=5, argv=0x7fffffffdfd8) at simsys.cc:825#13 0x0000555555a14f32 in main (argc=5, argv=0x7fffffffdfd8) at simsys_s2.cc:792
Debug: main_view_t::display: starting ...Debug: main_view_t::display: display pointer*** stack smashing detected ***: <unknown> terminatedThread 1 "simutrans-exten" received signal SIGABRT, Aborted.__GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:5151 ../sysdeps/unix/sysv/linux/raise.c: No such file or directory.
Message: interaction_t::interactive_event(event_t &ev): calling a toolMessage: tool_query_t(): checking map square 79,173,0Message: tool_query_t(): index 3Message: gui_textarea_t::recalc_size(): reset size to 11,0Message: event: 0,-16Message: gui_textarea_t::recalc_size(): reset size to 146,11*** stack smashing detected ***: <unknown> terminatedThread 1 "simutrans-exten" received signal SIGABRT, Aborted.__GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:5151 ../sysdeps/unix/sysv/linux/raise.c: No such file or directory.(gdb) backtrace#0 __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:51#1 0x00007ffff6767801 in __GI_abort () at abort.c:79#2 0x00007ffff67b0897 in __libc_message (action=action@entry=do_abort, fmt=fmt@entry=0x7ffff68dd988 "*** %s ***: %s terminated\n") at ../sysdeps/posix/libc_fatal.c:181#3 0x00007ffff685bcd1 in __GI___fortify_fail_abort (need_backtrace=need_backtrace@entry=false, msg=msg@entry=0x7ffff68dd966 "stack smashing detected") at fortify_fail.c:33#4 0x00007ffff685bc92 in __stack_chk_fail () at stack_chk_fail.c:29#5 0x00005555559b98df in number_to_string (p=0x7fffffffacf6 "", f=0, decimals=180) at utils/simstring.cc:208#6 0x3030303030303030 in ?? ()#7 0x3030303030303030 in ?? ()#8 0x3030303030303030 in ?? ()#9 0x0000303030303030 in ?? ()#10 0x0000000100426284 in ?? ()#11 0x0235023b0243e500 in ?? ()#12 0x40f4e5e15569000e in ?? ()#13 0xffffffff0000023b in ?? ()#14 0xffffffff00000019 in ?? ()#15 0x0000025000000000 in ?? ()#16 0x0000004e00000000 in ?? ()#17 0x0000000000000064 in ?? ()#18 0x00005555a4a1a308 in ?? ()#19 0x0000000000000000 in ?? ()
Quote from: Ranran on January 31, 2020, 11:33:30 AMI have added a theoretical high to the acceleration chart. This represents an acceleration graph with no load and unaffected by speed limits and slopes.
Quote from: Ranran on January 31, 2020, 11:33:30 AMI changed the "Access charges" chart button to violet because orange has some of duplication.
Quote from: Freahk on January 31, 2020, 12:29:21 PMhowever imho the theoretical max load acceleration rather than min load is the most important figure for comparisation.
Quote from: Freahk on January 31, 2020, 12:29:21 PMIn this case it would be some thing like (discussable):Total Capacity, TransportedAverage SpeedComfortRevenue, Running Costs, Profit, Access chargesDistanceAccelerationTractive Effort
Quote from: Ranran on January 31, 2020, 01:37:53 PMPerhaps (2) is wise?
Quote from: Ranran on January 31, 2020, 01:37:53 PMAbout color uniformity,Does it make sense to swap the colors of "Cash flow" and "Operating profit" in the Finance window?That is, match the color of "profit" in the convoy info dialog.
QuoteI am not sure how easy that it is to fix.
QuoteIdeally, the graph would end at the highest speed attainable and before the values drop to zero.
QuoteAlso, I notice that there are no tooltips for the buttons in the convoy window, but this is equally the case in the current master branch. Had it been intended to implement these?
Quote from: Ranran on August 02, 2020, 02:58:06 PMI think that was the cause of the crash on Linux.
Quote from: Freahk on August 02, 2020, 03:25:37 PMlalala std::array is nice, we all should like the stdlib.
QuoteI notice that Ranran has pushed some changes
Quotethe trunction seems to be off by one so far.
Quote from: freddyhayward on August 08, 2020, 12:42:22 PMThis branch still crashes on linux due to the use of char *.
Quote from: Ranran on August 10, 2020, 10:28:55 AMThank you for testing.The only new char variable I added is the button label, so I wonder if it was because I didn't enclose the added macro replacement list in parentheses. If not, I can't think of any other cause... (´・ω・｀)
Quote1. I don't think that these graphs belong with the history charts - they use a different x-axis and cannot be overlaid with them. If you have 3 history curves enabled, but then enable the acceleration curve, the other 3 disappear. Disable the acceleration curve and the 3 curves are still missing, but the different x-axis from the acceleration curve remains.
Quote2. The curve flaps up and down when the convoy is moving. This ought to be constant information.
Quote3. it is unclear what the x-axis means.
Quote4. it is unclear what the secondary line means, and it is impossible to see it clearly.
Quote from: jamespetts on August 18, 2020, 10:58:40 PMI think that, if the crash can be fixed, this patch in its current form is better than not having an acceleration graph even if it would be ideal to have the graphs in the depot one day. Ranran - can I check whether the crash has been fixed? If so, I can re-test and consider any more minor amendments that may be needed.
Quote from: freddyhayward on August 19, 2020, 01:39:40 AMI should just note that these crashes tend to occur on Linux rather than Windows, so it must be tested on Linux (which I will gladly do) before merging.
Quote from: jamespetts on August 25, 2020, 08:59:29 PMI have seen some (possibly conflicting) activity on Github relating to this
Quote from: Ranran on January 06, 2020, 06:02:29 AMIt was something like this.
Quote from: jamespetts on August 29, 2020, 11:15:47 AMIn relation to a GUI overhaul, I should be interested in your views on how that should interact with the much delayed work on convoy recombination and vehicle maintenance; the UI on this has been started by Ves some time ago, I think, but I am not sure how much work has been done in relation to it.
Quote from: Ranran on November 01, 2020, 05:13:28 AMIt would be helpful at this stage to see if it would cause a crash on linux as before.
Quote from: jamespetts on November 01, 2020, 02:11:09 PMCan I check whether this branch is intended to work alongside the master branch or one of the merge from Standard branches?