News:

Use the "Forum Search"
It may help you to find anything in the forum ;).

[Bug] Capacities in vehicle replace window don't increase beyond original

Started by CK, January 10, 2020, 04:12:35 PM

Previous topic - Next topic

0 Members and 1 Guest are viewing this topic.

CK

The capacities (both passenger, mail and goods) of a convoy do not increase beyond the capacity of the original (to be replaced) convoy in the replace vehicle window. It's a cosmetic bug but nonetheless a bit annoying.

Steps to reproduce:

  • build a train of a couple of cars
  • start the train
  • open the vehicle replace window and do something that would increase capacity
  • Shown capacity will not increase beyond the original convoy's capacity

Ranran(retired)

https://github.com/jamespetts/simutrans-extended/blob/7e076b469ad6c5e8e330f4f1d98478a20c26aa40/gui/components/gui_convoy_assembler.cc#L788
cnv-> get_vehicle_count() in this line does not return the expected value in the replace_frame case.

This seems to be due to counting taking into account the class changes applied in the class manager for the purpose of counting capacity with the code below, if so, in the case of a replace frame, I think we need to add code to count the capacity based on vehicles(vehicle_desc_t *desc).
There may be a smarter way, but at least the current code behaves as reported as a bug. (´・ω・`)
ひめしという日本人が開発者達の助言を無視して自分好みの機能をextendedに"強引に"実装し、
コードをぐちゃぐちゃにしてメンテナンスを困難にし(とりわけ道路と建物関連)、
挙句にバグを大量に埋め込み、それを知らんぷりして放置し(隠居するなどと言って)別のところに逃げ隠れて自分のフォーク(OTRP)は開発を続けている
その事実と彼の無責任さに日本人プレイヤーは目を向けるべき。らんらんはそれでやる気をなくした(´・ω・`)
他人の振り見て我が振り直せ。ひめしのようにならないために、らんらんが生み出したバグや問題は自分で修正しなくちゃね(´・ω・`)