The International Simutrans Forum

 

Author Topic: [BUG]: Line/schedule clears when editing schedule in depot on high-latency games  (Read 217 times)

0 Members and 1 Guest are viewing this topic.

Offline freddyhayward au

  • *
  • Posts: 117
  • Languages: EN
steps to reproduce:
begin server game with server_frames_ahead set to some arbitrarily high value, for example 64
connect with client
build depot and stops
create new line
create new convoy in depot
assign vehicle to line, then immediately click "Schedule"

resulting behaviour:
the schedule window reads "no line selected"
closing the schedule window will revert the convoy to "no schedule set"

Offline freddyhayward au

  • *
  • Posts: 117
  • Languages: EN
I created a pull request that appears to fix this, however since the change replaces 10 lines of code with a single line of code, I would recommend checking it thoroughly before merging it.

EDIT: The patch currently causes a separate crash, so should not yet be merged.
EDIT 2: I believe that crash has now been fixed.
« Last Edit: January 21, 2020, 06:39:08 AM by freddyhayward »

Offline Freahk

  • *
  • Posts: 577
  • Languages: DE, EN
Has this been incorporated?
If so, please always comment it in the forums as I will move items from the bugreport list to the changelog when they are incorporated. Watching git commuit history and searching for the refered thread is too complicated in that workflow.

Offline freddyhayward au

  • *
  • Posts: 117
  • Languages: EN
Yes, that was merged here: https://github.com/jamespetts/simutrans-extended/pull/126. I'll do this in future.

Offline jamespetts gb

  • Simutrans-Extended project coordinator
  • Moderator
  • *
  • Posts: 19273
  • Cake baker
    • Bridgewater-Brunel
  • Languages: EN
My apologies for not noting that this had been incorporated; now moved to the solved bug reports section.