The International Simutrans Forum

 

Author Topic: [BUG] signal reasignment not posible (box out of range)  (Read 466 times)

0 Members and 1 Guest are viewing this topic.

Online Freahk

  • Devotee
  • *
  • Posts: 1367
  • Languages: DE, EN
[BUG] signal reasignment not posible (box out of range)
« on: January 19, 2020, 12:40:47 PM »
Whilst invetigating another bug, I just noticed this one.

What happened?
I was trying to reassign a single signal but that did not seem to work at all.

How to reproduce?
- Open the reproduction case (yes, it is the same as the one I created to reproduce another bug)
- Reassign any single signal to the unused signalbox.
- - You will get an error stating "Cannot build this signal this far beyond any signalbox."
« Last Edit: January 19, 2020, 04:46:05 PM by Freahk »

Online jamespetts

  • Simutrans-Extended project coordinator
  • Administrator
  • *
  • Posts: 20373
  • Cake baker
    • Bridgewater-Brunel
  • Languages: EN
Re: [BUG] signal reasignment not posible (box out of range)
« Reply #1 on: January 19, 2020, 04:20:30 PM »
Thank you for the report: I believe that I have now fixed this. I should be grateful if you could re-test with the next nightly build.

Online Freahk

  • Devotee
  • *
  • Posts: 1367
  • Languages: DE, EN
Re: [BUG] signal reasignment not posible (box out of range)
« Reply #2 on: January 20, 2020, 03:52:40 PM »
Fixed.

However, "reassigning" a single signal to the same signalbox it is already connected to will raise "cannot transfer signals: unknown error"

Due to this infering unexpected behavior, it could quickly lead to some kind of "I don't know why but there seems to be something wrong in assignment" bugreports.
It should better of either not raise an error at all or raise a "no signals transfered. Source signalbox was the same as target." or something like this.

Online jamespetts

  • Simutrans-Extended project coordinator
  • Administrator
  • *
  • Posts: 20373
  • Cake baker
    • Bridgewater-Brunel
  • Languages: EN
Re: [BUG] signal reasignment not posible (box out of range)
« Reply #3 on: January 21, 2020, 11:55:20 PM »
I have now modified the code so that no error message is given when attempting to reassign a signal to the signalbox to which it is already assigned. I should be grateful if you could re-test with the next nightly build.

Online Freahk

  • Devotee
  • *
  • Posts: 1367
  • Languages: DE, EN
Re: [BUG] signal reasignment not posible (box out of range)
« Reply #4 on: February 13, 2020, 12:40:00 PM »
Fixed