News:

Want to praise Simutrans?
Your feedback is important for us ;D.

BR class 37 - rotations mismatched

Started by Vladki, January 22, 2020, 11:26:26 PM

Previous topic - Next topic

0 Members and 1 Guest are viewing this topic.

Vladki

The BR class 37 is rotated wrong way in depot.

jamespetts

I am afraid that I have not been able to reproduce this. May I ask in which livery that this problem occurs?
Download Simutrans-Extended.

Want to help with development? See here for things to do for coding, and here for information on how to make graphics/objects.

Follow Simutrans-Extended on Facebook.

Vladki

It is the liverytype[2]=BR-Large-Logo. the roations are messed up in the code. In some old version it was ok, as the file labels were messed up and corrected by this funny assignment in dat file. Now the rotations match the file labels, so the dat has to be put back ion order


EmptyImage[N][2]=./images/br-cl37-ll_E.0
EmptyImage[NE][2]=./images/br-cl37-ll_SE.0
EmptyImage[E][2]=./images/br-cl37-ll_S.0
EmptyImage[SE][2]=./images/br-cl37-ll_SW.0
EmptyImage[S][2]=./images/br-cl37-ll_W.0
EmptyImage[SW][2]=./images/br-cl37-ll_NW.0
EmptyImage[W][2]=./images/br-cl37-ll_N.0
EmptyImage[NW][2]=./images/br-cl37-ll_NE.0


A pull request is available with fixes for this and two other reported bugs:
https://github.com/jamespetts/simutrans-pak128.britain/pull/61
https://forum.simutrans.com/index.php/topic,18970.msg179900/topicseen.html#msg179900
https://forum.simutrans.com/index.php/topic,19293.0.html

Please have alook at the pull request, I'm not sure If I ddi not mess something up by pulling from you repository to mine first. Still the proper git workflow is a bit of mystery to me

jamespetts

Splendid, thank you for that: this fix seems to work. Now applied.
Download Simutrans-Extended.

Want to help with development? See here for things to do for coding, and here for information on how to make graphics/objects.

Follow Simutrans-Extended on Facebook.