News:

Congratulations!
 You've won the News Item Lottery! Your prize? Reading this news item! :)

Constraint errors in boat-horse.dat from SF-SVN

Started by Frank, April 23, 2016, 12:56:50 PM

Previous topic - Next topic

0 Members and 1 Guest are viewing this topic.

Frank

The Constraints of BoatHorsesDouble and BoatHorsesSingle seem to be a little confused.

example

boat-horse.dat
Quote
obj=vehicle
name=BoatHorsesSingle
....
Constraint[Prev][0]=none
Constraint[Next][0]=BoxBoatBulk
Constraint[Next][1]=BoxBoatLong
Constraint[Next][2]=BoxBoatPiece
Constraint[Next][3]=BoxBoatCool
Constraint[Next][4]=SteelHullDumbBargeBulk
Constraint[Next][5]=SteelHullDumbBargeLong
Constraint[Next][6]=SteelHullDumbBargePiece
Constraint[Next][7]=SteelHullDumbBargeCool
Constraint[Next][8]=SteelHullDumbBargeOil
Constraint[Next][9]=SteelHullDumbBargeLivestock
Constraint[Next][10]=WoodenHullDumbBargeBulk
Constraint[Next][11]=WoodenHullDumbBargeLong
Constraint[Next][12]=WoodenHullDumbBargePiece
Constraint[Next][13]=WoodenHullDumbBargeCool
Constraint[Next][14]=WoodenHullDumbBargeOil
Constraint[Next][15]=WoodenHullDumbBargeLivestock
Constraint[Next][16]=SteelHullUnpoweredNarrowboatBulk
Constraint[Next][17]=SteelHullUnpoweredNarrowboatLong
Constraint[Next][18]=SteelHullUnpoweredNarrowboatPiece
Constraint[Next][19]=SteelHullUnpoweredNarrowboatCool
Constraint[Next][20]=SteelHullUnpoweredNarrowboatMail
Constraint[Next][21]=SteelHullUnpoweredNarrowboatLivestock
Constraint[Next][22]=SteelHullUnpoweredNarrowboatOil
Constraint[Next][23]=CompositeHullUnpoweredNarrowboatBulk
Constraint[Next][24]=CompositeHullUnpoweredNarrowboatLong
Constraint[Next][25]=CompositeHullUnpoweredNarrowboatPiece
Constraint[Next][26]=CompositeHullUnpoweredNarrowboatCool
Constraint[Next][27]=CompositeHullUnpoweredNarrowboatMail
Constraint[Next][28]=CompositeHullUnpoweredNarrowboatLivestock
Constraint[Next][29]=CompositeHullUnpoweredNarrowboatOil
Constraint[Next][30]=WoodenHullUnpoweredNarrowboatBulk
Constraint[Next][31]=WoodenHullUnpoweredNarrowboatLong
Constraint[Next][32]=WoodenHullUnpoweredNarrowboatPiece
Constraint[Next][33]=WoodenHullUnpoweredNarrowboatCool
Constraint[Next][34]=WoodenHullUnpoweredNarrowboatMail
Constraint[Next][35]=WoodenHullUnpoweredNarrowboatLivestock
Constraint[Next][36]=WoodenHullUnpoweredNarrowboatOil
Constraint[Next][37]=TubBoatBulk
Constraint[Next][38]=TubBoatLong
Constraint[Next][39]=TubBoatPiece
Constraint[Next][40]=TubBoatCool
Constraint[Next][41]=MarketBarge
Constraint[Next][42]=MarketNarrowboat
Constraint[Next][43]=PacketBarge
Constraint[Next][44]=none

...
----
...

name=BoatHorsesDouble
...
Constraint[Prev][0]=none
Constraint[Next][0]=FlyboatPiece
Constraint[Next][1]=FlyboatCool
Constraint[Next][2]=FlyboatMail
Constraint[Next][3]=FlyboatPax
Constraint[Next][4]=SteelHullDumbBargeBulk
Constraint[Next][5]=none

undefined HorseBargeBulk, but HorseBargeBulk defines the horses

horse-barge.dat
Quoteobj=vehicle
name=HorseBargeBulk
...
Constraint[Prev][0]=BoatHorsesSingle
Constraint[Prev][1]=BoatHorsesDouble

Constraint[Prev][2]=SteamBargeBulk
Constraint[Prev][3]=SteamBargeLong
Constraint[Prev][4]=SteamBargePiece
Constraint[Prev][5]=SteamBargeCool
Constraint[Prev][6]=SteamBargeOil
Constraint[Prev][7]=DieselBargeBulk
Constraint[Prev][8]=DieselBargeLong
Constraint[Prev][9]=DieselBargePiece
Constraint[Prev][10]=DieselBargeCool
Constraint[Prev][11]=DieselBargeOil
Constraint[Prev][12]=SteamBargeLivestock
Constraint[Prev][13]=DieselBargeLivestock
Constraint[Next][0]=none


This also applies to other combinations.
All vehicles of horse-barge.dat are not defined with the horses.

Y5mpF3

#1
[EN] It has been simply forgotten to register the "new" barges with the tugs, not only in the horses. I tried to correct it, but did not manage it. Somebody should manage it.

[DE] Da wurde einfach vergessen, die "neuen" Schleppkähne auch bei den Schleppern einzutragen, nicht nur bei den Pferden. Ich habe einmal versucht, das zu korrigieren, aber nicht hinbekommen.

jamespetts

The Standard version of the pakset is no longer maintained, as both of the maintainers retired a few years ago. These work correctly in the Extended version of the pakset, which I maintain.
Download Simutrans-Extended.

Want to help with development? See here for things to do for coding, and here for information on how to make graphics/objects.

Follow Simutrans-Extended on Facebook.

Y5mpF3

But the erroneous constraint list is the same in both versions.

kierongreen

Quote from: jamespetts on March 03, 2019, 12:24:44 PM
The Standard version of the pakset is no longer maintained, as both of the maintainers retired a few years ago. These work correctly in the Extended version of the pakset, which I maintain.
Just as an observation I don't know about The Hood but I do monitor the forum and would certainly hope that pak128.Britain can be maintained in terms of bug fixes (like this) at the very least.

Y5mpF3

Somebody does it. There is a new version of pak128.britain with single paks, which makes something easier, and a new parameter in the simuconf.

jamespetts

Quote from: Y5mpF3 on March 20, 2019, 12:01:45 PM
Somebody does it. There is a new version of pak128.britain with single paks, which makes something easier, and a new parameter in the simuconf.

Are you referring to the Simutrans-Extended version? This is compiled automatically every night and has an individual .pak file for each object.
Download Simutrans-Extended.

Want to help with development? See here for things to do for coding, and here for information on how to make graphics/objects.

Follow Simutrans-Extended on Facebook.


jamespetts

Download Simutrans-Extended.

Want to help with development? See here for things to do for coding, and here for information on how to make graphics/objects.

Follow Simutrans-Extended on Facebook.

kierongreen

Quote from: Y5mpF3 on March 20, 2019, 01:38:13 PM
Maybe. It is the latest version on https://sourceforge.net/projects/simutrans/files/pak128.britain/
Until a new version is released as a zip you'll need to download source files from https://sourceforge.net/p/simutrans/code/HEAD/tree/ - the dat in question is at https://sourceforge.net/p/simutrans/code/HEAD/tree/pak128.Britain/boats/boat-horse.dat

If you are unable to compile these yourself you can try copying the paks from https://simutrans-germany.com/files/upload/horse-boat-21-mar-19.zip over the ones in your pak128.Britain directory.

Y5mpF3

Thank you very much! They works fine. But why
I has tried several variants of makeobj. But why my compilation does not work? Maybe that should be a new topic? I love that James Hood created the opportunity to play the game in 1750. But a little bit would have to be more worked out there. It is a pity that there are no more graphics by him. Even though I found in the britain-ex-files something not occuring in the standard version.