The International Simutrans Forum

 

Author Topic: Fix for wrong zoom label when re-opening minimap window  (Read 852 times)

0 Members and 1 Guest are viewing this topic.

Offline ceeac

  • Devotee
  • *
  • Posts: 247
Fix for wrong zoom label when re-opening minimap window
« on: May 17, 2020, 05:17:49 PM »
To reproduce the bug:
  • Open the minimap window
  • Make sure the zoom factor is not 1:1
  • Close and reopen the minimap window

Online Freahk

  • Devotee
  • *
  • Posts: 1496
  • Languages: DE, EN
Re: Fix for wrong zoom label when re-opening minimap window
« Reply #1 on: May 17, 2020, 07:08:51 PM »
I don't understand that bug.
I have opened the minimap window, zoomed in to 16:1, closed the window, opened it again and it was still 16:1.
The other way round, I have zoomed out to 1:16, did the same and it was still 1:16.

Offline ceeac

  • Devotee
  • *
  • Posts: 247
Re: Fix for wrong zoom label when re-opening minimap window
« Reply #2 on: May 17, 2020, 08:39:39 PM »
The label between the two left/right arrows always reads "1:1" for me when I open the minimap window, regardless of the actual zoom level of the minimap. The label is only updated to the correct value if the zoom level changes.

Online Freahk

  • Devotee
  • *
  • Posts: 1496
  • Languages: DE, EN
Re: Fix for wrong zoom label when re-opening minimap window
« Reply #3 on: May 17, 2020, 09:01:33 PM »
Ah I see, it's standard. Sorry about this.

Offline prissi

  • Developer
  • Administrator
  • *
  • Posts: 10622
  • Languages: De,EN,JP
Re: Fix for wrong zoom label when re-opening minimap window
« Reply #4 on: May 18, 2020, 01:13:42 PM »
That you, fixed in r9105

Offline captain crunch

  • *
  • Posts: 121
Re: Fix for wrong zoom label when re-opening minimap window
« Reply #5 on: July 16, 2020, 11:54:05 AM »
It does not work for me. The map window's behaviour is the same as described in the original post.

Offline kierongreen

  • Dev Team, Coder/patcher
  • Devotee
  • *
  • Posts: 2346
Re: Fix for wrong zoom label when re-opening minimap window
« Reply #6 on: July 16, 2020, 02:01:03 PM »
Seems to work for me what svn commit were you testing with captain crunch?

Offline captain crunch

  • *
  • Posts: 121
Re: Fix for wrong zoom label when re-opening minimap window
« Reply #7 on: July 17, 2020, 10:15:41 AM »
Always the latest.
Edit: I wonder: The window title says r8904, the credits/start window says r8903, but I did 'make clean' after checkout and before the build, so it should say r9170, no?
It just shows 1:1 when I open the window, even if the map is zoomed before.

Offline kierongreen

  • Dev Team, Coder/patcher
  • Devotee
  • *
  • Posts: 2346
Re: Fix for wrong zoom label when re-opening minimap window
« Reply #8 on: July 17, 2020, 11:16:17 AM »
Always the latest.
Edit: I wonder: The window title says r8904, the credits/start window says r8903, but I did 'make clean' after checkout and before the build, so it should say r9170, no?
It just shows 1:1 when I open the window, even if the map is zoomed before.
Yes it should say 9170 - are you sure it's an up to date release that's actually being run (e.g. can you select overlapping climates which prissi introduced in 9148 where each climate has an upper and a lower value)

Offline captain crunch

  • *
  • Posts: 121
Re: Fix for wrong zoom label when re-opening minimap window
« Reply #9 on: July 17, 2020, 06:35:03 PM »
D'oh! The error was indeed an outdated executable. I am sorry for the waste of time. Please accept my apology!

Offline kierongreen

  • Dev Team, Coder/patcher
  • Devotee
  • *
  • Posts: 2346
Re: Fix for wrong zoom label when re-opening minimap window
« Reply #10 on: July 17, 2020, 11:07:36 PM »
No worries - easy to happen!