The International Simutrans Forum

 

Author Topic: Destination colors Map vs Citiy info minimap  (Read 168 times)

0 Members and 1 Guest are viewing this topic.

Offline Milko

  • Devotee
  • *
  • Posts: 863
Destination colors Map vs Citiy info minimap
« on: May 21, 2020, 09:46:10 PM »
Hello.


When I see destinations on the map and in the city information minimap, are the colors the same? I took the help (listed below) and they look slightly different.


Thank's

Offline Freahk

  • *
  • Posts: 960
  • Languages: DE, EN
Re: Destination colors Map vs Citiy info minimap
« Reply #1 on: May 21, 2020, 10:44:36 PM »
I recently had a discusion about this on stephenson-siemens.
It sems like the description of the latter is not correct, but we were not sure about it.

We guessed that the meaning of pink and purple is actually swapped.

Offline Ranran

  • *
  • Posts: 865
  • Languages: ja
Re: Destination colors Map vs Citiy info minimap
« Reply #2 on: May 22, 2020, 12:00:33 AM »
It sems like the description of the latter is not correct, but we were not sure about it.

We guessed that the meaning of pink and purple is actually swapped.
Code: [Select]
case too_slow:
if(city && wtyp == goods_manager_t::passengers)
{
if(car_minutes >= best_journey_time)
{
city->merke_passagier_ziel(best_bad_destination, COL_LIGHT_PURPLE);
}
else if(car_minutes < UINT32_MAX_VALUE)
{
city->merke_passagier_ziel(best_bad_destination, COL_PURPLE);
}
else
{
// This should not occur but occasionally does.
goto no_route;
}
}
I found the code but I haven't checked if it matches the description.

Offline Milko

  • Devotee
  • *
  • Posts: 863
Re: Destination colors Map vs Citiy info minimap
« Reply #3 on: May 22, 2020, 07:05:23 AM »
Hello

But is the code of the map and that of the two minimaps city info the same?

Giuseppe

Offline Freahk

  • *
  • Posts: 960
  • Languages: DE, EN
Re: Destination colors Map vs Citiy info minimap
« Reply #4 on: May 22, 2020, 09:51:13 AM »
So it seems the description of minimaps destination layer is correct.
The description of townhalls map is also correct but less preciese and doesn't cover all cases.

Offline jamespetts

  • Simutrans-Extended project coordinator
  • Moderator
  • *
  • Posts: 19684
  • Cake baker
    • Bridgewater-Brunel
  • Languages: EN
Re: Destination colors Map vs Citiy info minimap
« Reply #5 on: May 22, 2020, 03:52:24 PM »
Thank you for pointing this out: I had forgotten that the text was duplicated. I have now made the two consistent.

Offline Freahk

  • *
  • Posts: 960
  • Languages: DE, EN
Re: Destination colors Map vs Citiy info minimap
« Reply #6 on: May 22, 2020, 03:57:33 PM »
I'd further like to point out that there might be an issue with private car too slow and public transport too slow recorded data or stop stats.

On stephenson-siemens, we had noticed many stops recording "too slow", whilst we couldn't find any purple but many pink pixels on the destination layer.

That's why we first assumed these two to be swapped.

Offline jamespetts

  • Simutrans-Extended project coordinator
  • Moderator
  • *
  • Posts: 19684
  • Cake baker
    • Bridgewater-Brunel
  • Languages: EN
Re: Destination colors Map vs Citiy info minimap
« Reply #7 on: May 22, 2020, 04:14:08 PM »
I'd further like to point out that there might be an issue with private car too slow and public transport too slow recorded data or stop stats.

On stephenson-siemens, we had noticed many stops recording "too slow", whilst we couldn't find any purple but many pink pixels on the destination layer.

That's why we first assumed these two to be swapped.

May I ask that this be posted as a separate bug report, or else I shall never remember that this may need looking into.