News:

Simutrans Sites
Know our official sites. Find tools and resources for Simutrans.

[FIX] Common desyncs on server reloading

Started by freddyhayward, August 09, 2020, 02:27:50 AM

Previous topic - Next topic

0 Members and 1 Guest are viewing this topic.

freddyhayward

I've made a pull request that, in my testing, fixes the notorious desync issues caused whenever force-syncs occur while editing schedules, names, etc. The problem was solved by simply reordering a few lines of code in the load function. View here:
https://github.com/jamespetts/simutrans-extended/pull/238

jamespetts

Splendid, thank you for that: now incorporated.
Download Simutrans-Extended.

Want to help with development? See here for things to do for coding, and here for information on how to make graphics/objects.

Follow Simutrans-Extended on Facebook.

freddyhayward

Thanks - I had made a TODO comment in one of my commits about the use of pre-increment (++i) when clearing the checklist history. Can you recall or guess why this was used?

jamespetts

Quote from: freddyhayward on August 09, 2020, 11:53:03 AM
Thanks - I had made a TODO comment in one of my commits about the use of pre-increment (++i) when clearing the checklist history. Can you recall or guess why this was used?

It was not me who wrote this code; I believe that this code was written by Bernd Gabriel many years ago, and I do not know how it works.
Download Simutrans-Extended.

Want to help with development? See here for things to do for coding, and here for information on how to make graphics/objects.

Follow Simutrans-Extended on Facebook.