Menu
Home
Help
Search
Login
Register
1 Hour
1 Day
1 Week
1 Month
Forever
The International Simutrans Forum
»
Development
»
Bug Reports
»
Known bugs and features
»
Topic:
[r9531] script tool icon is not shown when menu key contains ")"
« previous
next »
Print
Pages: [
1
]
Go Down
Author
Topic: [r9531] script tool icon is not shown when menu key contains ")" (Read 408 times)
0 Members and 1 Guest are viewing this topic.
THLeaderH
Coder/patcher
Devotee
Posts: 419
Languages: JP,EN
[r9531] script tool icon is not shown when menu key contains ")"
«
on:
January 09, 2021, 12:27:36 PM »
In r9531, the script tool icon is not shown in menubar when the menu key of the script tool contains ")" character. This is just a parsing problem and should be fixed with the attached patch.
Logged
prissi
Developer
Administrator
Posts: 10529
Languages: De,EN,JP
Re: [r9531] script tool icon is not shown when menu key contains ")"
«
Reply #1 on:
January 09, 2021, 12:36:30 PM »
I do not think that get_sound will work with that too. So maybe a little more effort is needed. Still submitted this, thank you.
Logged
THLeaderH
Coder/patcher
Devotee
Posts: 419
Languages: JP,EN
Re: [r9531] script tool icon is not shown when menu key contains ")"
«
Reply #2 on:
January 09, 2021, 01:16:25 PM »
script_tool_manager_t::fill_menu() does not take sound parameter. To be precise, the function ignores the sound argument.
Logged
prissi
Developer
Administrator
Posts: 10529
Languages: De,EN,JP
Re: [r9531] script tool icon is not shown when menu key contains ")"
«
Reply #3 on:
January 09, 2021, 01:50:10 PM »
But it should be possible to connect a sound to it, I think.
Logged
Dwachs
DevTeam, Coder/patcher
Administrator
Posts: 4849
Languages: EN, DE, AT
Re: [r9531] script tool icon is not shown when menu key contains ")"
«
Reply #4 on:
January 09, 2021, 02:55:55 PM »
This parameter is ignored in all these fill_menu methods.
Logged
prissi
Developer
Administrator
Posts: 10529
Languages: De,EN,JP
Re: [r9531] script tool icon is not shown when menu key contains ")"
«
Reply #5 on:
January 10, 2021, 12:12:32 PM »
Probably the get_sound() call should go then as well. Although building definitively makes noise.
Logged
Print
Pages: [
1
]
Go Up
« previous
next »
The International Simutrans Forum
»
Development
»
Bug Reports
»
Known bugs and features
»
Topic:
[r9531] script tool icon is not shown when menu key contains ")"