The International Simutrans Forum

 

Author Topic: display setting dialog issues  (Read 142 times)

0 Members and 1 Guest are viewing this topic.

Offline Ranran

  • Devotee
  • *
  • Posts: 1162
  • Languages: ja
display setting dialog issues
« on: September 16, 2020, 09:37:47 AM »
Thank you for your daily maintenance.
Report multiple small bugs. (´・ω・`)

(1) hide building setting combobox does not respond to shortcut key changes
For example, hide tree checkbox is sane, but it's not.



(2) The "show nothing" display is incorrect (a colored background is displayed), but as far as I can see in the code, the behavior seems unintended.
Code: [Select]
case 2:
display_outline_proportional_rgb( p.x + LINESPACE + D_H_SPACE, p.y, color_idx_to_rgb(COL_YELLOW), color_idx_to_rgb(COL_BLACK), text, 1 );
display_ddd_box_clip_rgb(         p.x,                     p.y,   LINESPACE,   LINESPACE,   pc-2, pc+2 );
display_fillbox_wh_clip_rgb(      p.x+1,                   p.y+1, LINESPACE-2, LINESPACE-2, pc,   true);
break;
case 3: // show nothing
break;



Also, I think the yellow text color looks better if the vertical alignment is middle.


(3)
display_settings.cc line 104,
Code: [Select]
// add controls to info container
add_table(2,3);
add_table(2,4) is correct. (Although it has no effect in standard, a layout error occurred when adding a table below it in extended.)

Offline prissi

  • Developer
  • Administrator
  • *
  • Posts: 10143
  • Languages: De,EN,JP
Re: display setting dialog issues
« Reply #1 on: September 16, 2020, 01:54:04 PM »
Thank you, fixed in r 9242