The International Simutrans Forum

 

Author Topic: Cities fail to find private car routes  (Read 306 times)

0 Members and 1 Guest are viewing this topic.

Offline freddyhayward

  • Devotee
  • *
  • Posts: 462
  • Languages: EN
Cities fail to find private car routes
« on: September 22, 2020, 03:49:43 AM »
Reproduction case:
1. Open the attached save.
2. Set max_route_tiles_to_process_in_a_step to any value between 0 and 65535 as it has no effect.
3. Fast-forward the save any amount of time.
4. Observe that no private car route between the two cities has been established, despite there being a direct road connection.

Offline jamespetts

  • Simutrans-Extended project coordinator
  • Administrator
  • *
  • Posts: 20354
  • Cake baker
    • Bridgewater-Brunel
  • Languages: EN
Re: Cities fail to find private car routes
« Reply #1 on: September 26, 2020, 10:53:31 PM »
I have just looked into this: that is because the townhall roads are not actually in the towns because the towns have no buildings and thus the town boundary is just the townhall itself.

For such a marginal situation as this, the amount of time that would be involved in devising a fix is not feasible at the present. In the future, when town growth is reworked, it might well be that this is able to eliminate the situation where a townhall road can be outside the town.

Offline freddyhayward

  • Devotee
  • *
  • Posts: 462
  • Languages: EN
Re: Cities fail to find private car routes
« Reply #2 on: September 27, 2020, 12:06:36 AM »
I have just looked into this: that is because the townhall roads are not actually in the towns because the towns have no buildings and thus the town boundary is just the townhall itself.

For such a marginal situation as this, the amount of time that would be involved in devising a fix is not feasible at the present. In the future, when town growth is reworked, it might well be that this is able to eliminate the situation where a townhall road can be outside the town.
In my testing, expanding both towns so that their townhall roads are within their boundaries causes a route for only one city to be created.

Offline jamespetts

  • Simutrans-Extended project coordinator
  • Administrator
  • *
  • Posts: 20354
  • Cake baker
    • Bridgewater-Brunel
  • Languages: EN
Re: Cities fail to find private car routes
« Reply #3 on: September 27, 2020, 12:18:01 AM »
In my testing, expanding both towns so that their townhall roads are within their boundaries causes a route for only one city to be created.

Can you upload the saved game in which you can reliably reproduce this so that I have a proper control with the exact parameters in which you have observed this?

Offline freddyhayward

  • Devotee
  • *
  • Posts: 462
  • Languages: EN
Re: Cities fail to find private car routes
« Reply #4 on: September 27, 2020, 01:03:23 AM »
In this save, private car routes were found to public buildings, but not between cities.

Offline Ranran

  • Devotee
  • *
  • Posts: 1286
  • Languages: ja
Re: Cities fail to find private car routes
« Reply #5 on: September 27, 2020, 04:53:44 AM »
Debug builds allow you to see which city or attraction the road has a route to.
But as reported in another thread, the dialog does not allow you to see all of the large amount of information.
Also, there seems to be a lot of information that can still be added. (For example, it is not possible to determine in which city multiple parks are located.)
Improving that dialog will make it easier to understand what is happening.

Offline jamespetts

  • Simutrans-Extended project coordinator
  • Administrator
  • *
  • Posts: 20354
  • Cake baker
    • Bridgewater-Brunel
  • Languages: EN
Re: Cities fail to find private car routes
« Reply #6 on: September 27, 2020, 11:11:39 AM »
Freddy - thank you for that reproduction case: that is very helpful. I think that I have now found and fixed this. It was caused when city destinations shared a tile with attraction or industry destinations.

I should be grateful if you could re-test with the next nightly build.

Offline freddyhayward

  • Devotee
  • *
  • Posts: 462
  • Languages: EN
Re: Cities fail to find private car routes
« Reply #7 on: September 27, 2020, 11:19:56 AM »
Freddy - thank you for that reproduction case: that is very helpful. I think that I have now found and fixed this. It was caused when city destinations shared a tile with attraction or industry destinations.

I should be grateful if you could re-test with the next nightly build.
There is a formatting error related to trailing whitespace causing the CI to fail. Aside from that, the issue appears to have been fixed.