The International Simutrans Forum

 

Author Topic: Fix for active player status when creating a new map  (Read 293 times)

0 Members and 1 Guest are viewing this topic.

Offline ceeac

  • Devotee
  • *
  • Posts: 269
Fix for active player status when creating a new map
« on: October 03, 2020, 08:23:01 AM »
This is somewhat related to this thread.

When starting a new map while another one with AI players activated is running, the "active player" status is not reset.
To reproduce the bug:
  • Load a map with AI players active or start a new map and activate AI players
  • Start a new map using the "new world" dialogue
  • Save
  • Close the game
  • Reload previous save
  • Save
  • Compare the two saves

Offline Dwachs

  • DevTeam, Coder/patcher
  • Administrator
  • *
  • Posts: 4899
  • Languages: EN, DE, AT
Re: Fix for active player status when creating a new map
« Reply #1 on: October 03, 2020, 08:39:56 AM »
In my opinion, settings.player_active is completely useless and should be removed. The active-state of each player is stored within player_t anyway. (also settings.player_type is close to useless)

Offline Dwachs

  • DevTeam, Coder/patcher
  • Administrator
  • *
  • Posts: 4899
  • Languages: EN, DE, AT
Re: Fix for active player status when creating a new map
« Reply #2 on: October 03, 2020, 09:21:50 AM »
removed this variable in r9260