The International Simutrans Forum

 

Author Topic: Were traffic light phase options recently removed?  (Read 356 times)

0 Members and 1 Guest are viewing this topic.

Offline freddyhayward

  • Devotee
  • *
  • Posts: 649
  • Languages: EN
Were traffic light phase options recently removed?
« on: January 24, 2021, 03:16:09 AM »
This may be a pakset issue. I recall being able to edit the different phases of traffic lights through the info GUI. I can't see these options any more.

Offline Ranran

  • Devotee
  • *
  • Posts: 1476
  • Languages: ja
Re: Were traffic light phase options recently removed?
« Reply #1 on: January 24, 2021, 04:23:58 AM »
I recall being able to edit the different phases of traffic lights through the info GUI. I can't see these options any more.
Since a meaningless and destructive option was provided, I think that the current form is simplified by incorporating a modified intersection behavior in standard and eliminating it.

That is, the current button layout is the same as standard.
Can't you achieve the behavior you expect using that button?

Offline freddyhayward

  • Devotee
  • *
  • Posts: 649
  • Languages: EN
Re: Were traffic light phase options recently removed?
« Reply #2 on: January 24, 2021, 06:02:02 AM »
That is, the current button layout is the same as standard.
Can't you achieve the behavior you expect using that button?
No. If a main route travels north and east from the intersection, I cannot set north and east to the long phase and south and west to the short phase. Also, I cannot set a direction to be in both phases.
What was the meaningless option? If it was removing a direction from both phases, just disable the ticked checkbox when it is only ticked for one phase, and re-enable it when both phases are ticked.

Offline Ranran

  • Devotee
  • *
  • Posts: 1476
  • Languages: ja
Re: Were traffic light phase options recently removed?
« Reply #3 on: January 24, 2021, 11:02:17 AM »
Quote
If a main route travels north and east from the intersection, I cannot set north and east to the long phase and south and west to the short phase
Please read these threads. The problems are listed there.
https://forum.simutrans.com/index.php/topic,20358.0.html
https://forum.simutrans.com/index.php/topic,20364.0.html

Originally it didn't do it right. There are a lot of bugs, breaking the link between signal light appearance and permission, and available as exploits, and there is no doubt that you will have to spend a great deal of effort modifying code to get them to work properly.

Anyway it is now back to the starting point. Anyone can start it.
It should be noted that the behavior at consecutive intersections was improved by prissi.
« Last Edit: January 24, 2021, 11:13:20 AM by Ranran »

Offline jamespetts

  • Simutrans-Extended project coordinator
  • Administrator
  • *
  • Posts: 20720
  • Cake baker
    • Bridgewater-Brunel
  • Languages: EN
Re: Were traffic light phase options recently removed?
« Reply #4 on: January 24, 2021, 11:49:18 AM »
Ranran - thank you for this. Can I check on which branch that these changes have been made? I cannot see them on your master branch.

Offline freddyhayward

  • Devotee
  • *
  • Posts: 649
  • Languages: EN
Re: Were traffic light phase options recently removed?
« Reply #5 on: January 24, 2021, 12:01:54 PM »
Please read these threads. The problems are listed there.
https://forum.simutrans.com/index.php/topic,20358.0.html
https://forum.simutrans.com/index.php/topic,20364.0.html

Originally it didn't do it right. There are a lot of bugs, breaking the link between signal light appearance and permission, and available as exploits, and there is no doubt that you will have to spend a great deal of effort modifying code to get them to work properly.

Anyway it is now back to the starting point. Anyone can start it.
It should be noted that the behavior at consecutive intersections was improved by prissi.
You have shown that the old system was unmaintainable. However, its function is sorely missed.

Offline Ranran

  • Devotee
  • *
  • Posts: 1476
  • Languages: ja
Re: Were traffic light phase options recently removed?
« Reply #6 on: January 24, 2021, 12:14:06 PM »
However, its function is sorely missed.
But on the other hand, the problem of intersection behavior has been resolved, eliminating the need for players to do the tedious work before they can achieve it. Usability has been greatly improved. Because player don't have to do anything to avoid stuck at a continuous intersection.
Also, exploit is no longer possible.
And I was able to merge it thanks to the simplification of the standard merging task. You have to pay a lot of effort to merge while maintaining the functionality and to normalize it.
Please note that the original functionality was rarely checked and had many issues.

Can I check on which branch that these changes have been made? I cannot see them on your master branch.
It is included in the GUI over haul.
https://github.com/Ranran-the-JuicyPork/simutrans-extended/commit/eef89d2d48e203b749f2d84079e0cee22cd2a857

The relevant commits for standard are r9268 and 9269.

Offline freddyhayward

  • Devotee
  • *
  • Posts: 649
  • Languages: EN
Re: Were traffic light phase options recently removed?
« Reply #7 on: January 24, 2021, 12:15:51 PM »
But on the other hand, the problem of intersection behavior has been resolved, eliminating the need for players to do the tedious work before they can achieve it. Usability has been greatly improved. Because player don't have to do anything to avoid stuck at a continuous intersection.
Also, exploit is no longer possible.
And I was able to merge it thanks to the simplification of the standard merging task. You have to pay a lot of effort to merge while maintaining the functionality and to normalize it.
I already demonstrated a use case for it. But I appreciate that there removing it has brought other improvements.

Offline Ranran

  • Devotee
  • *
  • Posts: 1476
  • Languages: ja
Re: Were traffic light phase options recently removed?
« Reply #8 on: January 24, 2021, 12:18:37 PM »
I already demonstrated a use case for it.
Even so, I think it's a good idea to start from the current state in order to incorporate standard improvements. Anyone who wants it can get started.
And, as I have already pointed out, the act of opening the north and the west at the same time creates a great contradiction with the signal light. Because the image has only two patterns.