Started by Ranran(retired), February 28, 2021, 12:55:51 PM
0 Members and 1 Guest are viewing this topic.
Quote from: prissi on February 28, 2021, 01:11:24 PMmore flexibility is certainly a good idea. However, I fear it would be up to you to make a patch. Some things are probably easy, while other may be very hard. So I would suggest a number of patcher obe by one.
Quote from: Ranran on February 28, 2021, 12:55:51 PM(3) Menu bar...The Menubar design depends on pakset and is separated from the theme. So it creates a contradiction with the theme design and creates a weird look. This fact shatters the minds of theme designers. (´・ω・｀)My suggestion is to separate the button background from the button icon.The theme designs the foundation and pakset designs the objects.I don't think the transition to this specification will cause any problems. Because all existing icons have the whole image.Not only does this remove the contradiction, but it also improves the look somewhat by not stretching the background with large buttons.
Quoteso something like the attached graphic will happen - and that's no good.
Quoteno pakset designer would check all themes when creating icons
QuoteOtherwise, I feel that p192c gets off the hook due to black outlines, which mean that really, only a black background would hurt them. Most paksets are not that lucky. Pretty sure no theme designer would check on all icon colors, and no pakset designer would check all themes when creating icons, so something like the attached graphic will happen - and that's no good.
Quote from: Ranran on May 04, 2021, 12:40:40 AMI'm afraid but you deliberately presented a bad design example
Quote from: Ranran on May 04, 2021, 12:40:40 AMOf course, there may be a mismatch between the icon provided by pakset and the theme. If they don't like the theme, players can choose not to use it.
Quote from: Vladki on May 05, 2021, 10:36:22 AM- what it would need is an agreement, how much space should be left for button-like border decorations. Now it is 2 pixels, this should be retained as a rule for theme designers, not to make the frames thicker.
Quote from: Ranran on February 28, 2021, 12:55:51 PM(1) The title bar is not beautifulCurrently the brightness of characters and background is automatically adjusted by gui_player_color_dark and gui_player_color_bright, but this is not enough. Especially on dark colored themes.Because this is intended to invert the brightness. But with a dark theme it is not always correct.I think the parameters related to the title bar and normal text brightness should be separated.Ideally, we should have a color mask like for color buttons.
Quote from: Ranran on February 28, 2021, 12:55:51 PM(2) Borders where theme can't specify a color will spoil the lookFor example, components such as progress bars, color boxes, and views have a two-color gray border.I want you to be able to specify the color of these borders as well.
boost_electric.set_transparent(fab->get_prodfactor_electric()>0 ? 0 : TRANSPARENT50_FLAG | OUTLINE_FLAG | color_idx_to_rgb(COL_BLACK)); boost_passenger.set_transparent(fab->get_prodfactor_pax()>0 ? 0 : TRANSPARENT50_FLAG | OUTLINE_FLAG | color_idx_to_rgb(COL_BLACK)); boost_mail.set_transparent(fab->get_prodfactor_mail()>0 ? 0 : TRANSPARENT50_FLAG | OUTLINE_FLAG | color_idx_to_rgb(COL_BLACK));
Quote from: prissi on January 16, 2022, 12:16:41 AMIn the convoi info line of combobox these are SYSCOL_TEXT. (gui_color_text)The entry to edit are SYSCOL_EDIT_TEXT or ..._DISABLED (gui_color_edit_text or ..._disabled)So they should be different
Quote from: Ranran on January 15, 2022, 11:42:49 PMThe color to be masked is fixed at black.
Quote from: Ranran on January 15, 2022, 11:42:49 PMHowever, it is not visible on a black background theme... (´・ω・｀)
Quote from: Ranran on January 17, 2022, 09:52:05 PMThis case do not exist in extended, but I think SYSCOL_TEXT should be used instead of COL_BLACK.Because SYSCOL_TEXT should always use a color with a certain visibility against the GUI background. So it will be suitable for any theme.