The International Simutrans Forum

 

Author Topic: Makeobj nightly can't compile on pak192.comic git  (Read 488 times)

0 Members and 1 Guest are viewing this topic.

Offline Flemmbrav

  • Devotee
  • *
  • Posts: 269
  • PAK-DEV P192C
  • Languages: DE, EN
Makeobj nightly can't compile on pak192.comic git
« on: June 14, 2021, 09:38:44 PM »
Hey there,

the usual "we did not change a thingy":

After this commit just now makeobj did not compile anyymore:
https://github.com/Flemmbrav/Pak192.Comic/commit/b843cc9786253ee84e38cf8ae2aec7c205d68cd3

Build scribt for nightlies:
https://github.com/Flemmbrav/Pak192.Comic/blob/Standard/.github/workflows/build_nightly.yml

Error from the compilation process tonight:

Quote
===> CXX ../io/classify_file.cc
In file included from ../io/classify_file.cc:17:
../io/../simversion.h:11:10: fatal error: revision.h: No such file or directory
   11 | #include "revision.h"
      |          ^~~~~~~~~~~~
compilation terminated.
make: *** [../uncommon.mk:54: ../build/default/io/classify_file-makeobj.o] Error 1
Error: Process completed with exit code 2.

Hmu in case you need more information.
I hope it ain't on us this time.  ;)

Offline Andarix

  • *
  • Posts: 314
  • Languages: de
Re: Makeobj nightly can't compile on pak192.comic git
« Reply #1 on: June 14, 2021, 10:30:07 PM »
Why is the exisiting working revision build system being broken?
Code: [Select]
===> HOSTCXX dataobj/environment.cc
In file included from dataobj/environment.cc:10:
dataobj/../simversion.h:10:10: fatal error: revision.h: No such file or directory
   10 | #include "revision.h"
      |          ^~~~~~~~~~~~
compilation terminated.
make: *** [common.mk:51: /r/build/dataobj/environment.o] Error 1


r9868 simversion.h:
--#if defined(REVISION_FROM_FILE)  &&  !defined(REVISION)
// include external generated revision file
#include "revision.h"
--#endif

revision.h is added .gitignore
Quote
Revision: 9720
Autor: ceeac
Datum: Freitag, 2. April 2021 12:13:52
Meldung:
Add MSVC generated directories and files to gitignore
----
Verändert : /simutrans/trunk/.gitignore


Offline prissi

  • Developer
  • Administrator
  • *
  • Posts: 10905
  • Languages: De,EN,JP
Re: Makeobj nightly can't compile on pak192.comic git
« Reply #2 on: June 15, 2021, 03:22:10 AM »
Both makefiles for Makeobj and Nettools had bitrot. Should be both ok again in r9892

Offline Flemmbrav

  • Devotee
  • *
  • Posts: 269
  • PAK-DEV P192C
  • Languages: DE, EN
Re: Makeobj nightly can't compile on pak192.comic git
« Reply #3 on: June 15, 2021, 08:56:41 AM »
Looking good! Thanks a lot for the fix.