News:

SimuTranslator
Make Simutrans speak your language.

[GUI] Cancel button in the install pakset window

Started by Yona-TYT, October 18, 2021, 06:25:35 PM

Previous topic - Next topic

0 Members and 1 Guest are viewing this topic.

Yona-TYT

 When we mistakenly enter the install pakset window, there is no way to go back, so for practical use we need a "Cancel" button to return us to the select pakset window.

prissi


Yona-TYT

Simutrans stops working when you use the new "cancel" button for the second time.

prissi

That is intended. There is no need to see this so many times, just one install and then start with that. But it can be easily changed.

Yona-TYT

I apologize for reviving this topic, (seemed appropriate to do so).  :-[ 
The cancel button doesn't work, but this time it's during the loaded game (not in the select paksets window).

prissi

Sorry, do you mean it does not work when called from the option window?

Yona-TYT


Quote from: prissi on February 20, 2022, 12:01:34 PM
Sorry, do you mean it does not work when called from the option window?
exactly, at least that happens here in Linux fedora.

prissi


Roboron

Since r10485 it shows itself in an additional windows instead of its own screen https://github.com/aburch/simutrans/commit/2f5ddbe57716ab56b84de7c272bcb6d44171cbfa#diff-110c80a8fa76ec8f5023c7ca4a5cef0ec9b202330cd0893f753896c7afc20b90

But then the cancel button was not updated to call destroy_win when pressed.

But after prissi's last comment, I am not sure what its intention was/is.

prissi

Indeed, the destroy windows call was missing. Should work again in r10499

Yona-TYT

Quote from: prissi on February 21, 2022, 07:08:11 AM
Indeed, the destroy windows call was missing. Should work again in r10499
The "Cancel" button still doesn't work.  :-[

prissi

#11
In this case the cancel button is rather useless, since the window can be closed manually anyway. Also the install path was not used. Should work more like intended in r10554