The International Simutrans Forum

 

Author Topic: Display settings in settings_stats.cc  (Read 512 times)

0 Members and 1 Guest are viewing this topic.

Offline Sirius

  • Devotee
  • *
  • Posts: 1651
  • Languages: DE, EN
Display settings in settings_stats.cc
« on: September 13, 2021, 03:02:41 PM »
In simutrans, there are multiple setting windows.
This is about display settings UI (display_settings.cc) and the "advanced settings" UI (settings_stats.cc)
Some settings only exist in the display settings UI, whilst a few exist in both.
I am wondering whether this is intended or not.

This was observed in extended, but I can conform that it applies at least to show_month in standard as well. It seems likely that it applies to further attributes, but I did not check this further.
The only ones that exist in both (again observed in extended) are left_to_right_graphs, show_month, show_names, pedes_and_car_info and follow_convoi_underground.

It doesn't make much sense to me for these to exist in the advanced settings dialogue, so I assume these should be deleted over there.
If that's correct, I might prepare a patch.
If not, I'd like to get a brief description about what makes these different from the other display settings, so I can stick to this guideline.
« Last Edit: September 13, 2021, 03:30:49 PM by Freahk »

Offline TurfIt

  • Dev Team, Coder/patcher
  • Devotee
  • *
  • Posts: 1445
Re: Display settings in settings_stats.cc
« Reply #1 on: September 13, 2021, 04:39:50 PM »
IMHO "advanced settings" should contain settings_t variables, display settings should contain env_t variables.  i.e. Advanced settings is the interface for modifying those variables saved in the save game (at risk of breaking the game). And, not all env_t settings make sense to have in a GUI.

Related, with how often settings.xml breaks (especially in Extended), it's rather poor choice for storing user preferences. Ideally fix the continual breakage. But, IMHO better to have simuconf.tab as the prime place for user preferences to be set - and have settings.xml take precedence (I understand the order is backwards at the moment [atleast for Extended]).


Offline prissi

  • Developer
  • Administrator
  • *
  • Posts: 10979
  • Languages: De,EN,JP
Re: Display settings in settings_stats.cc
« Reply #2 on: September 14, 2021, 01:13:33 AM »
I agree that some of the display settings maybe should not be in the extended settings. It was like this: All settings (that make sense) in simuconf.tab should be also in the advanced settings. However, this rule is broken when the same setting (like starting year or climate related) is also more prominently available. Hence, it would be more consequent to have the display settings only in the display dialoge.

Offline Sirius

  • Devotee
  • *
  • Posts: 1651
  • Languages: DE, EN
Re: Display settings in settings_stats.cc
« Reply #3 on: September 14, 2021, 08:06:56 AM »
Thanks for the quick reply.
That conforms to my thoughts, I'll put an effort in this.

I might also include the most recent change from extended, which moves pedes_and_car_info to the display settings and allows to enable car and pedestrian infowindows independently of each other.
« Last Edit: September 14, 2021, 10:15:30 AM by Freahk »