News:

Simutrans.com Portal
Our Simutrans site. You can find everything about Simutrans from here.

setting parameter "max_speed_drive_by_sight_tram" is not saved correctly

Started by Ranran(retired), January 15, 2022, 09:39:38 PM

Previous topic - Next topic

0 Members and 1 Guest are viewing this topic.

Ranran(retired)

https://github.com/jamespetts/simutrans-extended/blob/b93b03c82c2496c57bf2e5b5f225c9ca2c521e9d/dataobj/settings.cc#L1734

if ((file->get_extended_version() == 14 && file->get_extended_revision()) >= 31 || file->get_extended_version() >= 15)
{
file->rdwr_long(max_speed_drive_by_sight_tram);
max_speed_drive_by_sight_tram = kmh_to_speed(max_speed_drive_by_sight_tram);
}

An error in the if statement suggests that this has not been saved correctly since implementation.
Pull request # 466 contains a fix for this.
ひめしという日本人が開発者達の助言を無視して自分好みの機能をextendedに"強引に"実装し、
コードをぐちゃぐちゃにしてメンテナンスを困難にし(とりわけ道路と建物関連)、
挙句にバグを大量に埋め込み、それを知らんぷりして放置し(隠居するなどと言って)別のところに逃げ隠れて自分のフォーク(OTRP)は開発を続けている
その事実と彼の無責任さに日本人プレイヤーは目を向けるべき。らんらんはそれでやる気をなくした(´・ω・`)
他人の振り見て我が振り直せ。ひめしのようにならないために、らんらんが生み出したバグや問題は自分で修正しなくちゃね(´・ω・`)

jamespetts

Download Simutrans-Extended.

Want to help with development? See here for things to do for coding, and here for information on how to make graphics/objects.

Follow Simutrans-Extended on Facebook.