News:

The Forum Rules and Guidelines
Our forum has Rules and Guidelines. Please, be kind and read them ;).

PR#479 - Implies that the button will open another window

Started by Ranran(retired), January 24, 2022, 03:30:53 AM

Previous topic - Next topic

0 Members and 1 Guest are viewing this topic.

Ranran(retired)

This is a kind of "More graphical symbol!" pooroejct that Ranran has been promoting for a long time. (´・ω・`)

Web page buttons may have a button design that implies opening another window.
I thought it would be useful if the buttons in the simutrans GUI could be done the same way.
Pull request #479 provides such functionality. That said, you can rest assured that simutrans will not lead you to a malicious money collection website. So you don't even need a pop-up blocker. ;)

In order for this to work, pakset must have a symbol for it. Otherwise, it will just keep the same appearance as before.


An example of a design is an arrow pointing to the upper right. Therefore, it would not be too difficult to create it.


I attach an icon pak for testing.

Obj=symbol
name=OpenWindow
copyright=Ranran
Image[0]=> ex-gui-icons.2.3
--------------------
ひめしという日本人が開発者達の助言を無視して自分好みの機能をextendedに"強引に"実装し、
コードをぐちゃぐちゃにしてメンテナンスを困難にし(とりわけ道路と建物関連)、
挙句にバグを大量に埋め込み、それを知らんぷりして放置し(隠居するなどと言って)別のところに逃げ隠れて自分のフォーク(OTRP)は開発を続けている
その事実と彼の無責任さに日本人プレイヤーは目を向けるべき。らんらんはそれでやる気をなくした(´・ω・`)
他人の振り見て我が振り直せ。ひめしのようにならないために、らんらんが生み出したバグや問題は自分で修正しなくちゃね(´・ω・`)

jamespetts

This is very interesting, thank you for this. Can I just confirm what exactly that I need to compile to test this and where I need to look out for it?
Download Simutrans-Extended.

Want to help with development? See here for things to do for coding, and here for information on how to make graphics/objects.

Follow Simutrans-Extended on Facebook.

Ranran(retired)

Quote from: jamespetts on January 25, 2022, 10:33:49 PMCan I just confirm what exactly that I need to compile to test this and where I need to look out for it?
The patch is pull request #479.
Please put the OpenWindow.pak file attached to the first post in the pakset folder.
To update the pakset, you need to update the attached image (ex-gui-icons.png) and add the aforementioned line to gui_symbols.dat.
The pakset creators can also provide their own unique design.
ひめしという日本人が開発者達の助言を無視して自分好みの機能をextendedに"強引に"実装し、
コードをぐちゃぐちゃにしてメンテナンスを困難にし(とりわけ道路と建物関連)、
挙句にバグを大量に埋め込み、それを知らんぷりして放置し(隠居するなどと言って)別のところに逃げ隠れて自分のフォーク(OTRP)は開発を続けている
その事実と彼の無責任さに日本人プレイヤーは目を向けるべき。らんらんはそれでやる気をなくした(´・ω・`)
他人の振り見て我が振り直せ。ひめしのようにならないために、らんらんが生み出したバグや問題は自分で修正しなくちゃね(´・ω・`)

jamespetts

Excellent, thank you. Now incorporated (both code and pakset).
Download Simutrans-Extended.

Want to help with development? See here for things to do for coding, and here for information on how to make graphics/objects.

Follow Simutrans-Extended on Facebook.