News:

Want to praise Simutrans?
Your feedback is important for us ;D.

Crash on loading Bridgewater-Brunel save

Started by jamespetts, January 30, 2022, 11:47:33 AM

Previous topic - Next topic

0 Members and 1 Guest are viewing this topic.

jamespetts

The Bridgewater-Brunel server is down this morning because of a new crash on loading the saved game. The saved game is here.

Testing with an older build, I confirm that this loads without crashing or other apparent error. Therefore, this would appear to be an issue introduced with yesterday's modifications.

The crash is in loading the first halt - it is an index out of bounds in the waiting time, trying to read back 9 values when there are in fact only 5 classes. This suggests that the error has actually occurred in the previous part of the loading, the lines, by them either loading too many or too few data, meaning that the file stream is in the wrong position by the time that it comes to reading the halts. Alternatively, the problem might have occurred earlier in the halt loading process.

I have not made any changes myself to this part of the code - I wonder whether the issue might have been caused by Ranran's changes to records for amounts of things transported or being processed at halts?
Download Simutrans-Extended.

Want to help with development? See here for things to do for coding, and here for information on how to make graphics/objects.

Follow Simutrans-Extended on Facebook.

Ranran(retired)

Sorry about that. I think an error in the revision number caused it.  :-[
Please check the pull request #484.
ひめしという日本人が開発者達の助言を無視して自分好みの機能をextendedに"強引に"実装し、
コードをぐちゃぐちゃにしてメンテナンスを困難にし(とりわけ道路と建物関連)、
挙句にバグを大量に埋め込み、それを知らんぷりして放置し(隠居するなどと言って)別のところに逃げ隠れて自分のフォーク(OTRP)は開発を続けている
その事実と彼の無責任さに日本人プレイヤーは目を向けるべき。らんらんはそれでやる気をなくした(´・ω・`)
他人の振り見て我が振り直せ。ひめしのようにならないために、らんらんが生み出したバグや問題は自分で修正しなくちゃね(´・ω・`)

jamespetts

Download Simutrans-Extended.

Want to help with development? See here for things to do for coding, and here for information on how to make graphics/objects.

Follow Simutrans-Extended on Facebook.