Crash after convoy withdraw or sell

[michal.]

Hello,

I've encountered a weird bug that crashes the game immediately after selling or withdrawing some vehicles.

Reproduction
1) Load attached game: https://ufile.io/17gd08c8
2) Go to convoy 2080 at 377:3119 and click on "Sell now" or "Withdraw" button
3) The game crashes

The crash happens also after withdrawing fly-boat convoy 2949 at 307:2331 and some other vehicles. Some convoys are affected, while other can be withdrawn without any problems. I'm not aware of anything suspicious that could have caused the bug.

Unfortunately, I have not been able to reproduce the bug in minimal game.

I've tested the most recent Windows and Linux versions with the same outcome.
Below is the relevant debug message. Afterwards, the program stops responding and SIGSEGV error is printed out...

Code Select Expand

Debug: convoi::dump():
vehicle_count = 5
wait_lock = 0
owner_n = 0
akt_speed = 89
sp_soll = 1489
state = 6
statename = DRIVING
alte_direction = 2
jahresgewinn = -139
name = '(2080) Pack horses (long goods)'
line_id = '188'
schedule = '0x56518a46bcb0'

I would be very happy to help with anything.

[Ranran(retired)]

Thank you for reporting the bug.
I can certainly recreate the crash.
I suppose it may be related to the incorporation of r10351 and 10352.

[Ranran(retired)]

In the standard version, the schedule editing function was included in the convoy info, but not in the extended version. I think I was adding unnecessary processing.
Now I think I have fixed it. Please check pull request #483.

[jamespetts]

Excellent, thank you. Fix now incorporated.

[michal.]

Thank you very much, Ranran and James! I can confirm that withdrawing works well in today's version.

[jamespetts]

Splendid, thank you for confirming.